From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E03C4167D for ; Tue, 14 Nov 2023 13:10:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233093AbjKNNKQ (ORCPT ); Tue, 14 Nov 2023 08:10:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232320AbjKNNKO (ORCPT ); Tue, 14 Nov 2023 08:10:14 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86506185; Tue, 14 Nov 2023 05:10:11 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6BD0E1F86A; Tue, 14 Nov 2023 13:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699967409; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UdKGYYZPHz9oLSF/GPQkv/zIiz3pCkDlwsJZ0EvwJbg=; b=pGL5QXsf/7kDX/csv7iPatJ1hr20Ed7DP93tWdxUz9c0HRzODX0L8kKo8O2lfowVVYkOlQ nXMWwt9f9EpC0WsNK1lJF9HjQKqASfQIRabPjeETRtF4VUWLTCHECDCZQ6dOyoiPqBjTr4 jV7hYDADDTyEKAVq5R+yP50+CFeozsw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699967409; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UdKGYYZPHz9oLSF/GPQkv/zIiz3pCkDlwsJZ0EvwJbg=; b=en1gL9PqCX6jpKmEy0HXVI/fVksJKcxwkpwHalI+ttO5VUlyvm74JxEJHY6PtG/kVX1zjo lY5ul88kqei5LqDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F90B13460; Tue, 14 Nov 2023 13:10:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eX2dDrFxU2XeAwAAMHmgww (envelope-from ); Tue, 14 Nov 2023 13:10:09 +0000 Date: Tue, 14 Nov 2023 14:10:08 +0100 Message-ID: <87r0kstr9r.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , , , "Simon Trimmer" Subject: Re: [PATCH RESEND] ALSA: hda: cs35l56: Enable low-power hibernation mode on i2c In-Reply-To: <20231113164029.1156669-1-rf@opensource.cirrus.com> References: <20231113164029.1156669-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-3.12 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[7]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.02)[52.16%] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Nov 2023 17:40:29 +0100, Richard Fitzgerald wrote: > > From: Simon Trimmer > > This can now be re-enabled as the sequence to reliably wake the device > has been implemented in the shared ASoC code. > > This has a functional dependency on commit 3df761bdbc8b > ("ASoC: cs35l56: Wake transactions need to be issued twice") > > To protect against this, enabling hibernation is conditional on > CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new > hibernation sequences are available. > > Signed-off-by: Simon Trimmer > Signed-off-by: Richard Fitzgerald Thanks, applied. Takashi