From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 346F0C4332F for ; Mon, 13 Nov 2023 09:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233416AbjKMJsS (ORCPT ); Mon, 13 Nov 2023 04:48:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233396AbjKMJsQ (ORCPT ); Mon, 13 Nov 2023 04:48:16 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 142F110D for ; Mon, 13 Nov 2023 01:48:13 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8F944218E2; Mon, 13 Nov 2023 09:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699868891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1vFSfCAesxj5T4w6xSCczF9wyS9xME2aks+RySw/rPs=; b=TmaIFB6ZrFuwc59dYyU/p7M5elwysKyNlG8jKQw/IduIqY1+GJHSgHnbM8NHJH7fXvw6PE a6B0zXzzM6cGw2lrCTx2IQQsVVQGW6sjsxsoqLVB5e02g7wLg4+kW4Rw0QKo5i6CZeUP8H GWNoIVutR62w81l5sxs8VD0xnHCrSdk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699868891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1vFSfCAesxj5T4w6xSCczF9wyS9xME2aks+RySw/rPs=; b=2/6SsiYAqRwGwxijnWXZEDFuKU4JjNfJh3WtaYUOo0STkEL88ZaAIb/Udt07s/cfhlDkKc U6RgHw/BSDNhWUDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 680F613398; Mon, 13 Nov 2023 09:48:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Cw+DGNvwUWWaFwAAMHmgww (envelope-from ); Mon, 13 Nov 2023 09:48:11 +0000 Date: Mon, 13 Nov 2023 10:48:10 +0100 Message-ID: <87r0kuoug5.wl-tiwai@suse.de> From: Takashi Iwai To: Matus Malych Cc: tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 255 G10 In-Reply-To: <20231112161821.6754-1-matus@malych.org> References: <20231112161821.6754-1-matus@malych.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 12 Nov 2023 17:18:22 +0100, Matus Malych wrote: > > HP 255 G10 has a mute LED that can be made to work using quirk > ALC236_FIXUP_HP_MUTE_LED_COEFBIT2. Enable already existing quirk. > > Signed-off-by: Matus Malych Thanks for the patch. The quirk entries are sorted in PCI SSID order. Could you correct the position to put and resubmit? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index cdd808e02b44..bda4e9cb8f98 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9833,6 +9833,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8902, "HP OMEN 16", ALC285_FIXUP_HP_MUTE_LED), > SND_PCI_QUIRK(0x103c, 0x890e, "HP 255 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), > + SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2), > SND_PCI_QUIRK(0x103c, 0x8919, "HP Pavilion Aero Laptop 13-be0xxx", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x896d, "HP ZBook Firefly 16 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x896e, "HP EliteBook x360 830 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), > -- > 2.34.1 >