From: Thomas Gleixner <tglx@linutronix.de>
To: James Tai <james.tai@realtek.com>,
linux-kernel@vger.kernel.org,
linux-realtek-soc@lists.infradead.org
Cc: Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver
Date: Mon, 06 Nov 2023 18:06:01 +0100 [thread overview]
Message-ID: <87r0l2hkw6.ffs@tglx> (raw)
In-Reply-To: <20231102142731.2087245-4-james.tai@realtek.com>
On Thu, Nov 02 2023 at 22:27, James Tai wrote:
> +
> +enum rtd1319_iso_isr_bits {
> + RTD1319_ISO_ISR_TC3_SHIFT = 1,
> + RTD1319_ISO_ISR_UR0_SHIFT = 2,
Please use tabular formatting all over the place.
> + RTD1319_ISO_ISR_LSADC0_SHIFT = 3,
> + RTD1319_ISO_ISR_IRDA_SHIFT = 5,
> +
> +static const struct realtek_intc_info rtd1319_intc_iso_info = {
> + .isr_offset = 0x0,
> + .umsk_isr_offset = 0x4,
> + .scpu_int_en_offset = 0x40,
Magic numbers. Defines exist for a reason.
next prev parent reply other threads:[~2023-11-06 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 14:27 [PATCH 0/6] Initial support for the Realtek interrupt controller James Tai
2023-11-02 14:27 ` [PATCH 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs James Tai
2023-11-03 6:49 ` Krzysztof Kozlowski
2023-11-16 14:37 ` James Tai [戴志峰]
2023-11-16 14:46 ` Krzysztof Kozlowski
2023-11-02 14:27 ` [PATCH 2/6] irqchip: Add interrupt controller " James Tai
2023-11-06 11:30 ` Thomas Gleixner
2023-11-16 15:25 ` James Tai [戴志峰]
2023-11-17 9:44 ` James Tai [戴志峰]
2023-11-02 14:27 ` [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver James Tai
2023-11-06 4:26 ` kernel test robot
2023-11-06 17:06 ` Thomas Gleixner [this message]
2023-11-16 15:29 ` James Tai [戴志峰]
2023-11-02 14:27 ` [PATCH 4/6] irqchip: Introduce RTD1319D " James Tai
2023-11-06 4:03 ` kernel test robot
2023-11-02 14:27 ` [PATCH 5/6] irqchip: Introduce RTD1325 " James Tai
2023-11-06 7:00 ` kernel test robot
2023-11-02 14:27 ` [PATCH 6/6] irqchip: Introduce RTD1619B " James Tai
2023-11-06 10:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0l2hkw6.ffs@tglx \
--to=tglx@linutronix.de \
--cc=james.tai@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox