From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948A3C4332F for ; Wed, 1 Nov 2023 08:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234043AbjKAImu (ORCPT ); Wed, 1 Nov 2023 04:42:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232599AbjKAIms (ORCPT ); Wed, 1 Nov 2023 04:42:48 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA13210A for ; Wed, 1 Nov 2023 01:42:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32B04C433C8; Wed, 1 Nov 2023 08:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698828165; bh=ozX3xFq99mFRbsS81bQ5fZFxjBVkOqPDcIsEAJ+Lues=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Kqo4/LP7B0+wofG3zApbAt5dDJ5jIDUGxfFf4DxI6ffwnD1TztcocNjXrtDuKG0Yf b3eTfUrgf68zqEQs09gYoYA7FRbEbqVWXRmCqnW5kmqdxxIXjAfa26qYY2lHP5Ij1x iNEzG6kOuKpOIVTZTAhKurBMeW8lEUnKYhv4dBi8zeztyc3jfDKLQsnfXZxlnzMI59 Rq2NceCBbWMOY4WHBHDZZjVg09fZGk1upq1IaqplUg2fFeVYSGCO9szjY9gYVOsvOS VIeN55X3vq1kl5bX/nMxBoNGZ2OcpB3oAJri0PqlkoeDTZR0GldSxG3+ESZbJOzSNq PzVLdSe2G9r/g== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qy6oD-009Rpm-QU; Wed, 01 Nov 2023 08:42:42 +0000 Date: Wed, 01 Nov 2023 08:42:41 +0000 Message-ID: <87r0l96f0e.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Richard Cc: Aswath Govindraju , Vignesh Raghavendra , Nishanth Menon , Tero Kristo , Santosh Shilimkar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Gregory CLEMENT Subject: Re: [PATCH] irqchip/ti-sci-intr: Add support for system suspend/resume PM In-Reply-To: <184d23fc-bb62-473c-8400-cda160aa44f3@bootlin.com> References: <20220607061912.12222-1-a-govindraju@ti.com> <87sfohyma5.wl-maz@kernel.org> <0733f59a-497a-351b-0e97-26a2875a5352@ti.com> <871qvzr01u.wl-maz@kernel.org> <184d23fc-bb62-473c-8400-cda160aa44f3@bootlin.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: thomas.richard@bootlin.com, a-govindraju@ti.com, vigneshr@ti.com, nm@ti.com, kristo@kernel.org, ssantosh@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gregory.clement@bootlin.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Oct 2023 16:00:59 +0000, Thomas Richard wrote: > > On 6/8/22 11:12, Marc Zyngier wrote: > > On Wed, 08 Jun 2022 09:48:20 +0100, > > Aswath Govindraju wrote: > >> > >> As, the resource allocator does not have enough memory to save and > >> restore all the mappings corresponding various resources, this is being > >> done on the requester or consumer side. > > > > You're missing the point: the ti_sci_resource structure is managed by > > this resource allocator, and it isn't exactly rocket science to add > > the required context to it, and then get it to restore that context on > > resume. > > Hi Marc, > > I'm interested to continue the work to upstream this patch. > I read all the thread, but I think I'm also missing the point. > > Do you mean the ti_sci_intr_irq_domain struct is not the right place to > save the mappings, and it shall not be done in this irqchip driver? > The context should be saved and restored from the ti_sci driver using > the ti_sci_resource struct? That's exactly my point. There is already a large body of code that is aware of the resource allocation (the ti_sci driver), which is common to a whole lot of subsystem that will need some form of save/restore. It seems natural to put the save/restore aspects inside that driver, unless there is some other reasons not to do so (which haven't so far been explained). Thanks, M. -- Without deviation from the norm, progress is not possible.