* [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency
@ 2023-09-14 0:05 Randy Dunlap
2023-09-14 2:09 ` Rahul Rameshbabu
2023-09-18 14:55 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-09-14 0:05 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Rahul Rameshbabu, Jiri Kosina, Benjamin Tissoires,
linux-input
The hid-nvidia-shield driver uses functions that are built
only when LEDS_CLASS is set, so make the driver depend on that
symbol to prevent build errors.
riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11':
hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister'
riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113':
hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext'
Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD
tristate "NVIDIA SHIELD devices"
depends on USB_HID
depends on BT_HIDP
+ depends on LEDS_CLASS
help
Support for NVIDIA SHIELD accessories.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency
2023-09-14 0:05 [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency Randy Dunlap
@ 2023-09-14 2:09 ` Rahul Rameshbabu
2023-09-18 14:55 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Rahul Rameshbabu @ 2023-09-14 2:09 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, linux-input
On Wed, 13 Sep, 2023 17:05:17 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> The hid-nvidia-shield driver uses functions that are built
> only when LEDS_CLASS is set, so make the driver depend on that
> symbol to prevent build errors.
>
> riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11':
> hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister'
> riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113':
> hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext'
>
> Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD
> tristate "NVIDIA SHIELD devices"
> depends on USB_HID
> depends on BT_HIDP
> + depends on LEDS_CLASS
> help
> Support for NVIDIA SHIELD accessories.
Thanks for the patch. This also reminds me that the same needs to be
done for POWER_SUPPLY since support was added for the controller's
battery. I will send out a patch for that soon.
Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency
2023-09-14 0:05 [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency Randy Dunlap
2023-09-14 2:09 ` Rahul Rameshbabu
@ 2023-09-18 14:55 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2023-09-18 14:55 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Rahul Rameshbabu, Benjamin Tissoires, linux-input
On Wed, 13 Sep 2023, Randy Dunlap wrote:
> The hid-nvidia-shield driver uses functions that are built
> only when LEDS_CLASS is set, so make the driver depend on that
> symbol to prevent build errors.
>
> riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L11':
> hid-nvidia-shield.c:(.text+0x192): undefined reference to `led_classdev_unregister'
> riscv32-linux-ld: drivers/hid/hid-nvidia-shield.o: in function `.L113':
> hid-nvidia-shield.c:(.text+0xfa4): undefined reference to `led_classdev_register_ext'
>
> Fixes: 09308562d4af ("HID: nvidia-shield: Initial driver implementation with Thunderstrike support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: linux-input@vger.kernel.org
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -799,6 +799,7 @@ config HID_NVIDIA_SHIELD
> tristate "NVIDIA SHIELD devices"
> depends on USB_HID
> depends on BT_HIDP
> + depends on LEDS_CLASS
Aplied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-18 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-14 0:05 [PATCH] HID: nvidia-shield: add LEDS_CLASS dependency Randy Dunlap
2023-09-14 2:09 ` Rahul Rameshbabu
2023-09-18 14:55 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox