From: Takashi Iwai <tiwai@suse.de>
To: SungHwan Jung <onenowy@gmail.com>
Cc: fabian@ritter-vogt.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx
Date: Thu, 24 Aug 2023 19:44:04 +0200 [thread overview]
Message-ID: <87r0ns8hej.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230824173718.7992-1-onenowy@gmail.com>
On Thu, 24 Aug 2023 19:37:18 +0200,
SungHwan Jung wrote:
>
> On Fri, Aug 25, 2023 at 12:57 AM Fabian Vogt <fabian@ritter-vogt.de> wrote:
> > I see that SungHwan Jung (CC'd) recently submitted the same fixup for
> > a rather similar but different model as
> > "ALSA: hda/realtek: Add quirk for HP Victus 16-d1xxx to enable mute LED"
> > Does your HP Victus also need the ALC245_FIXUP_HP_GPIO_LED? Then we could
> > combine the quirks.
>
> These victus laptops don't need ALC245_FIXUP_HP_GPIO_LED, but we can make
> alc245_fixup_hp_x360_mute_led and alc245_fixup_hp_mute_led_coefbit into
> one function.
ShungHwan's patch was already merged, so we can just reuse the
function in a new quirk; ALC245_FIXUP_HP_X360_MUTE_LED will be calling
alc245_fixup_hp_mute_led_coefbit and chained to
ALC245_FIXUP_HP_GPIO_LED.
Fabian, could you resubmit such a patch?
thanks,
Takashi
next prev parent reply other threads:[~2023-08-24 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 15:57 [PATCH] ALSA: hda/realtek: Add quirk for mute LEDs on HP ENVY x360 15-eu0xxx Fabian Vogt
2023-08-24 17:37 ` SungHwan Jung
2023-08-24 17:44 ` Takashi Iwai [this message]
2023-08-24 18:39 ` [PATCH v2] " Fabian Vogt
2023-08-25 7:49 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0ns8hej.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=fabian@ritter-vogt.de \
--cc=linux-kernel@vger.kernel.org \
--cc=onenowy@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox