From: Takashi Iwai <tiwai@suse.de>
To: Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ALSA: pcmtest: Move buffer iterator initialization to prepare callback
Date: Tue, 08 Aug 2023 14:45:33 +0200 [thread overview]
Message-ID: <87r0odhfde.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230804110740.9867-1-ivan.orlov0322@gmail.com>
On Fri, 04 Aug 2023 13:07:39 +0200,
Ivan Orlov wrote:
>
> Trigger callback is not the best place for buffer iterator
> initialization, so move it out to the prepare callback, where it
> have to be.
>
> Minor enhancement: remove blank line.
>
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
> ---
> V1 -> V2:
> - Split changes in the patch into two different patches
Thanks, applied both patches now.
Takashi
prev parent reply other threads:[~2023-08-08 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 11:07 [PATCH v2 1/2] ALSA: pcmtest: Move buffer iterator initialization to prepare callback Ivan Orlov
2023-08-04 11:07 ` [PATCH v2 2/2] ALSA: pcmtest: Remove redundant definitions Ivan Orlov
2023-08-08 12:45 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0odhfde.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=ivan.orlov0322@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox