From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D427C7EE23 for ; Tue, 30 May 2023 07:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230501AbjE3HQP (ORCPT ); Tue, 30 May 2023 03:16:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230459AbjE3HPz (ORCPT ); Tue, 30 May 2023 03:15:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02CE190 for ; Tue, 30 May 2023 00:15:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7473D62AE5 for ; Tue, 30 May 2023 07:15:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D61ABC4339B; Tue, 30 May 2023 07:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685430951; bh=X+BQQC4rj6ECAJci4wdH+HxbQRJqFPTHu0vmtpJ2wLk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KRBDqNd3TjiBDur7/H8etO2RqXb/WtjlFUeXjcMwxFqG+F0j9Yl/vrOKfyp75rIY7 v90qRATHlP1UhTI7/HHKjtERBh2hk8hQJF+xr+GrtkiK6Bjc/V3Vrs7pLTiv79y74i Xt8RrLWylthnWdOY/VdZ86Fv/UEH56lAR90bUfy2gmq3sKo/F+nbucPTLY3LFTvv4N KtuHXQGpI9CxFcL8U8r1K4TY5iOauWVSOfyEiSRHoID+vPdFTjQzql07gLfKKuLOcS Gt6vFQ4ecqcZ0M7hfoKRssmctO2a1s9Nnc0ILRUWLIUkmbKlAUDmfE9exBwu9AMfw7 csqdW9JWAfYFg== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q3ta9-001Dwc-88; Tue, 30 May 2023 08:15:49 +0100 Date: Tue, 30 May 2023 08:15:47 +0100 Message-ID: <87r0qyjnmk.wl-maz@kernel.org> From: Marc Zyngier To: Yan =?UTF-8?B?WmhlbmfvvIjkuKXmlL/vvIk=?= Cc: "linux-kernel@vger.kernel.org" , Gao =?UTF-8?B?TWVpdGFv77yI6auY546r5rab77yJ?= , =?UTF-8?B?Ilpob3UgUWlhbyjlkajkvqgpIg==?= , "tglx@linutronix.de" , =?UTF-8?B?IlpoYW5nIFpoaXpob3Uo?= =?UTF-8?B?5byg5rK75rSyKSI=?= Subject: Re: [PATCH v2] irqchip/gic-v3: workaround for ASR8601 when reading mpidr In-Reply-To: <6452e00de4e446ddb25588e29fa9e768@exch03.asrmicro.com> References: <20230517075500.43516-1-zhengyan@asrmicro.com> <20230522110643.3063073-1-zhengyan@asrmicro.com> <87sfbfji4q.wl-maz@kernel.org> <6452e00de4e446ddb25588e29fa9e768@exch03.asrmicro.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: zhengyan@asrmicro.com, linux-kernel@vger.kernel.org, meitaogao@asrmicro.com, qiaozhou@asrmicro.com, tglx@linutronix.de, zhizhouzhang@asrmicro.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 May 2023 07:07:21 +0100, Yan Zheng=EF=BC=88=E4=B8=A5=E6=94=BF=EF=BC=89 wrote: >=20 > > I came up with the following patch, which keeps the workaround *in > > a single spot*. > >=20 > > Let me know if that works for you. > >=20 > > M. > >=20 >=20 > Really thanks for your help, this patch works well for us. > My previous patch was too ugly, this one looks better. I didn't find this= good solution. > Should I send a patch for v3, considering that you're the author? See [1]. I've split the refactoring in its own patch, and kept your authorship for what is left of the workaround code. No need to resend, I'll queue that for 6.5. M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/l= og/?h=3Dirq/gic-v3-asr8601 --=20 Without deviation from the norm, progress is not possible.