public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sean Anderson <sean.anderson@seco.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: retire_capture_urb: Corrected urb data len
Date: Sun, 28 Aug 2022 09:49:35 +0200	[thread overview]
Message-ID: <87r110iz8w.wl-tiwai@suse.de> (raw)
In-Reply-To: <9d41eda1-1172-ea60-dd87-b3e38a529170@seco.com>

On Fri, 26 Aug 2022 20:57:53 +0200,
Sean Anderson wrote:
> 
> On 8/26/22 12:36 PM, Takashi Iwai wrote:
> > On Fri, 26 Aug 2022 18:22:24 +0200,
> > Sean Anderson wrote:
> >> 
> >> Hi all,
> >> 
> >> I have a "FiiO DigiHug USB Audio" sound card (1852:7022) [3]. I have had
> >> no problems with the audio, but I did notice a large number of message
> >> like 
> >> 
> >> retire_capture_urb: 4992 callbacks suppressed
> >> 
> >> in my dmesg [1]. This is caused by the "Corrected urb data len."
> >> warning.
> > 
> > What exact values are shown there?
> 
> Unfortunately, as detailed below, I was unable to turn off ratelimiting.
> 
> > The problem is that your hardware
> > (likely a buggy firmware) returns the unaligned size of bytes as the
> > data.  Maybe it's worth to replace dev_warn_ratelimited() there with
> > dev_warn() and take all warnings once.  Then we can see what kind of
> > values are delivered from the hardware.
> 
> I'll have an attempt at that next week
> 
> >> The patch adding this warning [2] makes it seem like
> >> this warning should be an uncommon occurance. However, based on the
> >> number of suppressed callbacks, this seems to be happening at a rate of
> >> around 500 Hz.
> >> 
> >> Is this buggy hardware? Or is this a bug in the driver? Does there need
> >> to be a quirk? Or perhaps the warning above should be a debug instead?
> > 
> > There is no quirk for that.  As long as the device works with that
> > workaround (except for messages), we can simply add a quirk to not
> > warn but always apply the workaround silently for such devices.
> 
> OK. I wasn't sure what the correct resolution would be.

Actually I was wrong: the existing quirk QUIRK_FLAG_ALIGN_TRANSFER
should cover that.

Could you try to pass quirk_flags=0x04 for the corresponding card slot
(the option takes an array) to snd-usb-audio module?  Alternatively,
try to pass quirk_alias=18557022:0e510408 to snd-usb-audio?


thanks,

Takashi

  reply	other threads:[~2022-08-28  7:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 16:22 retire_capture_urb: Corrected urb data len Sean Anderson
2022-08-26 16:36 ` Takashi Iwai
2022-08-26 18:57   ` Sean Anderson
2022-08-28  7:49     ` Takashi Iwai [this message]
2022-09-01 15:25       ` Sean Anderson
2022-09-02  5:52         ` Takashi Iwai
2025-07-31 21:49           ` Sean Anderson
2025-08-01  8:50             ` Takashi Iwai
2025-08-01 15:35               ` Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r110iz8w.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sean.anderson@seco.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox