From: Kalle Valo <kvalo@kernel.org>
To: Yongzhi Liu <lyz_cs@pku.edu.cn>
Cc: amitkarwar@gmail.com, ganapathi017@gmail.com,
sharvari.harisangam@nxp.com, huxinming820@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, arend.vanspriel@broadcom.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, fuyq@stu.pku.edu.cn
Subject: Re: [PATCH] mwifiex: Fix potential dereference of NULL pointer
Date: Thu, 19 May 2022 18:37:19 +0300 [thread overview]
Message-ID: <87r14p1qkw.fsf@kernel.org> (raw)
In-Reply-To: <1652957839-127949-1-git-send-email-lyz_cs@pku.edu.cn> (Yongzhi Liu's message of "Thu, 19 May 2022 03:57:19 -0700")
Yongzhi Liu <lyz_cs@pku.edu.cn> writes:
> If 'card' is not valid, then we need to check the
> field 'adapter' and 'priv_num' to avoid use of NULL
> pointer in function 'mwifiex_get_priv'. Fix this by
> adding the null pointer check on them.
Why? We don't add null checks for every access, why does this function
need it?
How did you find this? Is this something you found with a static checker
tool or by testing with a real device?
> Fixes: 21c5c83ce ("mwifiex: support sysfs initiated device coredump")
Format is wrong, it should be:
Fixes: 21c5c83ce833 ("mwifiex: support sysfs initiated device coredump")
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-05-19 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 10:57 [PATCH] mwifiex: Fix potential dereference of NULL pointer Yongzhi Liu
2022-05-19 15:37 ` Kalle Valo [this message]
2022-05-19 15:52 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r14p1qkw.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=amitkarwar@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fuyq@stu.pku.edu.cn \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lyz_cs@pku.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharvari.harisangam@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox