From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75136C433EF for ; Thu, 12 May 2022 11:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353384AbiELLmb (ORCPT ); Thu, 12 May 2022 07:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351802AbiELLm2 (ORCPT ); Thu, 12 May 2022 07:42:28 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E44BE4F46C for ; Thu, 12 May 2022 04:42:27 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1652355746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EVKP/CYD5WiRAwea0fTycBrdnFzk/dVADr23qqt3y6E=; b=yrM5b6CodxR2cEHq4O3/hGD/yoinjSXq508BQzpZXowAZKXggW7cRyLYPM17mprPsosYk8 y9PSIdLgVvo8aYVBhWwA5DKYgK0MCuaHNGHNw9WypMDVzm5IAvh8l2++DiS2jD484+QY75 vKdaG3yKz6by4RwQkOy4V91hgeKiHqLzbQt+P6SjO9WDnbf31AbOXICv4hXgOToeC6tBgV rMiFxfAIyxO5DTXfoBVD5quJgNt+ZQnLQ8p534EeigGoO6fyFFkrw2q0fqYzjYQsFiuoAa 7BRkXVWjLgLnXXWZf4u7AmVNl5yWu++tVq2puGNxkGbvtuBYcLGX3y+tP9/lDA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1652355746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EVKP/CYD5WiRAwea0fTycBrdnFzk/dVADr23qqt3y6E=; b=xf0GqhLbq32Lzl8BtioR0084QfhMYTfAm3uM6gWUTLub59ppH2+6ubDOuiv8IvhfmlciBg NlrQ+MLhYo704wBw== To: Hans de Goede , kernel test robot , Peter Zijlstra Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Andy Shevchenko , linux-kernel@vger.kernel.org, Tony Luck Subject: Re: [pdx86-platform-drivers-x86:review-hans 46/59] kernel/stop_machine.c:638:35: error: call to undeclared function 'cpu_smt_mask'; ISO C99 and later do not support implicit function declarations In-Reply-To: References: <202205120904.Gr9HEY5E-lkp@intel.com> <87zgjnw1bg.ffs@tglx> Date: Thu, 12 May 2022 13:42:26 +0200 Message-ID: <87r14zvuxp.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12 2022 at 11:53, Hans de Goede wrote: > On 5/12/22 11:24, Thomas Gleixner wrote: >> On Thu, May 12 2022 at 09:29, kernel test robot wrote: >>>>> kernel/stop_machine.c:638:35: error: call to undeclared function 'cpu_smt_mask'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] >>> const struct cpumask *smt_mask = cpu_smt_mask(cpu); >> >> This warning with W=1 is not the worst of the problems. >> >> The build will simply fail for CONFIG_SMP=y && CONFIG_SCHED_SMT=n >> because cpu_smt_mask() cannot be resolved. >> >> The other issue is CONFIG_SMP=n. This will fail to build the IFS driver >> because stop_core_cpuslocked() is not available for SMP=n. > > The IFS Kconfig already depends on SMP : > > config INTEL_IFS > tristate "Intel In Field Scan" > depends on X86 && 64BIT && SMP > select INTEL_IFS_DEVICE > help > Enable ... > > > So I don't think we need the non-SMP implementation inside > include/linux/stop_machine.h, we only need the #ifdef you > suggest in kernel/stop_machine.c ? For the case at hand that's sufficient. > I think it is best to just squash this into the original > patch, do you agree ? Yes.