From: John Ogness <john.ogness@linutronix.de>
To: Marco Elver <elver@google.com>,
elver@google.com, Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
Thomas Gleixner <tglx@linutronix.de>,
Johannes Berg <johannes.berg@intel.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH -printk] printk, tracing: fix console tracepoint
Date: Tue, 03 May 2022 21:20:44 +0206 [thread overview]
Message-ID: <87r15ae8d7.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20220503073844.4148944-1-elver@google.com>
On 2022-05-03, Marco Elver <elver@google.com> wrote:
> One notable difference is that by moving tracing into printk_sprint(),
> the 'text' will no longer include the "header" (loglevel and timestamp),
> but only the raw message. Arguably this is less of a problem now that
> the console tracepoint happens on the printk() call and isn't delayed.
Another slight difference is that messages composed of LOG_CONT pieces
will trigger the tracepoint for each individual piece and _never_ as a
complete line.
It was never guaranteed that all LOG_CONT pieces make it into the final
printed line anyway, but with this change it will be guaranteed that
they are always handled separately.
I am OK with this change, but like Steven, I agree the the users of that
tracepoint need to chime in.
Acked-by: John Ogness <john.ogness@linutronix.de>
The ongoing printbuf/seq_buf work [0] will hopefully someday do away
with LOG_CONT altogether.
John
[0] https://lwn.net/Articles/892611
next prev parent reply other threads:[~2022-05-03 19:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 7:38 [PATCH -printk] printk, tracing: fix console tracepoint Marco Elver
2022-05-03 16:15 ` Steven Rostedt
2022-05-03 19:14 ` John Ogness [this message]
2022-05-04 9:46 ` Petr Mladek
2022-05-06 14:51 ` Petr Mladek
2022-05-06 14:55 ` Marco Elver
2022-07-11 22:29 ` Steven Rostedt
2022-07-12 0:21 ` Paul E. McKenney
2022-07-12 0:53 ` Steven Rostedt
2022-07-12 2:57 ` Paul E. McKenney
2022-07-12 11:49 ` Paul E. McKenney
2022-07-12 13:39 ` Steven Rostedt
2022-07-12 13:49 ` Paul E. McKenney
2022-07-12 14:53 ` Steven Rostedt
2022-07-12 15:16 ` Paul E. McKenney
2022-07-13 11:25 ` Petr Mladek
2022-07-13 14:05 ` Paul E. McKenney
2022-07-14 14:53 ` Petr Mladek
2022-07-14 15:17 ` Steven Rostedt
2022-07-15 9:40 ` Petr Mladek
2022-07-12 15:25 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r15ae8d7.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=johannes.berg@intel.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox