From: Daniel Axtens <dja@axtens.net>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, mpe@ellerman.id.au
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/iommu/debug: Remove redundant NULL check
Date: Fri, 26 Mar 2021 16:53:30 +1100 [thread overview]
Message-ID: <87r1k2795x.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <1616406217-94635-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Hi Jiapeng Chong, <jiapeng.chong@linux.alibaba.com> writes:
> Fix the following coccicheck warnings:
>
> ./fs/io_uring.c:5989:4-9: WARNING: NULL check before some freeing
> functions is not needed.
This looks correct to me, and matches the description of debugfs_remove
in Documentation/filesystems/debugfs.rst.
If you have a number of similar fixes it might be helpful to do them in
a single bigger patch, but I'm not sure if coccicheck reports much else
as I don't have coccinelle installed at the moment.
Reviewed-by: Daniel Axtens <dja@axtens.net>
Kind regards,
Daniel
next prev parent reply other threads:[~2021-03-26 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 9:43 [PATCH] powerpc/iommu/debug: Remove redundant NULL check Jiapeng Chong
2021-03-26 5:53 ` Daniel Axtens [this message]
2021-03-26 6:12 ` Daniel Axtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1k2795x.fsf@linkitivity.dja.id.au \
--to=dja@axtens.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox