From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BC4C433E0 for ; Sun, 24 Jan 2021 19:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B2B022D58 for ; Sun, 24 Jan 2021 19:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbhAXTCi (ORCPT ); Sun, 24 Jan 2021 14:02:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:37982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726535AbhAXTCc (ORCPT ); Sun, 24 Jan 2021 14:02:32 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0AD122CF6; Sun, 24 Jan 2021 19:01:51 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1l3kdx-009lho-MZ; Sun, 24 Jan 2021 19:01:49 +0000 Date: Sun, 24 Jan 2021 19:01:48 +0000 Message-ID: <87r1majh0j.wl-maz@kernel.org> From: Marc Zyngier To: David Brazdil Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Alexandru Elisei , Ard Biesheuvel , Jing Zhang , Ajay Patil , Prasad Sodagudi , Srinivas Ramana , James Morse , Julien Thierry , Suzuki K Poulose , kernel-team@android.com Subject: Re: [PATCH v4 15/21] arm64: Add an aliasing facility for the idreg override In-Reply-To: <20210118131839.7ao33jeufq3dfnb4@google.com> References: <20210118094533.2874082-1-maz@kernel.org> <20210118094533.2874082-16-maz@kernel.org> <20210118131839.7ao33jeufq3dfnb4@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: dbrazdil@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, alexandru.elisei@arm.com, ardb@kernel.org, jingzhangos@google.com, pajay@qti.qualcomm.com, psodagud@codeaurora.org, sramana@codeaurora.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jan 2021 13:18:39 +0000, David Brazdil wrote: > > On Mon, Jan 18, 2021 at 09:45:27AM +0000, Marc Zyngier wrote: > > In order to map the override of idregs to options that a user > > can easily understand, let's introduce yet another option > > array, which maps an option to the corresponding idreg options. > > > > Signed-off-by: Marc Zyngier > Acked-by: David Brazdil > > > --- > > arch/arm64/kernel/idreg-override.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c > > index 75d9845f489b..16bc8b3b93ae 100644 > > --- a/arch/arm64/kernel/idreg-override.c > > +++ b/arch/arm64/kernel/idreg-override.c > > @@ -37,6 +37,12 @@ static const struct reg_desc * const regs[] __initdata = { > > &mmfr1, > > }; > > > > +static const struct { > > + const char * const alias; > > + const char * const feature; > > +} aliases[] __initdata = { > > +}; > > + > > static int __init find_field(const char *cmdline, const struct reg_desc *reg, > > int f, u64 *v) > > { > > @@ -80,6 +86,18 @@ static void __init match_options(const char *cmdline) > > } > > } > > > > +static __init void match_aliases(const char *cmdline) > > +{ > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(aliases); i++) { > > + char *str = strstr(cmdline, aliases[i].alias); > > + > > + if ((str == cmdline || (str > cmdline && *(str - 1) == ' '))) > > nit: Extract to a 'cmdline_contains' helper? Took me a good few seconds to > parse this in the previous patch. Giving it a name would help, and now it's > also shared. Good point. Adopted! Thanks, M. -- Without deviation from the norm, progress is not possible.