From: NeilBrown <neil@brown.name>
To: George Hilliard <thirtythreeforty@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
"Nishad Kamdar" <nishadkamdar@gmail.com>,
"Sergej Perschin" <ser.perschin@gmail.com>,
"John Crispin" <blogic@openwrt.org>
Subject: Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.
Date: Wed, 03 Apr 2019 06:51:49 +1100 [thread overview]
Message-ID: <87r2ak18yy.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CACmrr9hZRiw10dDVcvFUFB7ZFzFq-WfELRXnTLOM_j5LoNnw3A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
On Tue, Apr 02 2019, George Hilliard wrote:
> On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> wrote:
>
>> The license text in this driver is "interesting" and not really obvious
>> that it is supposed to be able to be distributed in the kernel source
>> tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but
>> to be safe, I am deleting this driver. I will be glad to add it back if
>> the license is properly sorted out, but for now, this isn't worth the
>> potential risk, I should have never taken it in the first place.
>>
>
> So, for what it's worth, this driver has an obvious heritage of having been
> modified from the main Mediatek MMC driver. Now, of course it's *possible*
> to distribute GPL-incompatible changes to a GPL program, but the only
> *compliant* way to distribute these changes would have been the GPL.
>
> So there's a very good chance that it's intended to be GPL. (Which is
> good, because I need this driver!) I suppose we need to reach out to the
> original contributor.
People keep telling me that drivers/mmc/host/mtk-sd.c should be able to
handle the same hardware as this driver, with a little bit of work.
Unfortunately they haven't told me what the little bit of work involves.
Have you explored that possibility at all? I might try to have a look
if I can make time.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-04-02 19:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 10:31 [PATCH 00/16] staging: fix up remaining SPDX problems in drivers/staging Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 01/16] staging: add missing SPDX lines to Kconfig files Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 02/16] staging: add missing SPDX lines to Makefile files Greg Kroah-Hartman
2019-04-02 12:06 ` Mukesh Ojha
2019-04-03 9:06 ` Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 03/16] staging: m57621-mmc: delete driver from the tree Greg Kroah-Hartman
[not found] ` <CACmrr9hZRiw10dDVcvFUFB7ZFzFq-WfELRXnTLOM_j5LoNnw3A@mail.gmail.com>
2019-04-02 11:27 ` Greg Kroah-Hartman
2019-04-02 19:51 ` NeilBrown [this message]
2019-04-02 20:46 ` Christian Lütke-Stetzkamp
2019-04-02 23:57 ` NeilBrown
2019-04-03 19:35 ` George Hilliard
2019-04-07 23:41 ` NeilBrown
2019-04-02 10:31 ` [PATCH 04/16] staging: sm750fb: add proper SPDX identifier to driver Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 05/16] staging: vc04_services: add proper SPDX identifier for dual licensed files Greg Kroah-Hartman
2019-04-02 10:37 ` Stefan Wahren
2019-04-02 10:31 ` [PATCH 06/16] staging: vc04_services: remove remaining redundant license text Greg Kroah-Hartman
2019-04-02 10:37 ` Stefan Wahren
2019-04-03 9:07 ` Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 07/16] staging: comedi: quatec_daqp_cs: add proper SPDX identifier to driver Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 08/16] staging: iio: add proper SPDX identifiers to remaining driver files Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 09/16] staging: rtl8192u: add proper SPDX identifiers on files that did not have them Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 10/16] staging: ralink-gdma: add proper SPDX identifiers on ralink-gdma file Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 11/16] staging: rtl8192e: add proper SPDX identifiers on files that did not have them Greg Kroah-Hartman
2019-04-02 10:31 ` [PATCH 12/16] staging: rtl8192e: delete license file Greg Kroah-Hartman
2019-04-02 10:32 ` [PATCH 13/16] staging: media: zoran: add proper SPDX identifiers on files that did not have them Greg Kroah-Hartman
2019-04-02 10:32 ` [PATCH 14/16] staging: media: soc_camera: " Greg Kroah-Hartman
2019-04-02 10:32 ` [PATCH 15/16] staging: media: imx: " Greg Kroah-Hartman
2019-04-02 19:24 ` Steve Longerbeam
2019-04-02 10:32 ` [PATCH 16/16] staging: media: tegra-vde: add proper SPDX identifiers on file that did not have it Greg Kroah-Hartman
2019-04-02 13:59 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ak18yy.fsf@notabene.neil.brown.name \
--to=neil@brown.name \
--cc=blogic@openwrt.org \
--cc=christian@lkamp.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nishadkamdar@gmail.com \
--cc=ser.perschin@gmail.com \
--cc=thirtythreeforty@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox