Re: [PATCH v2] drm/vc4: Add a debugfs entry to disable/enable the load tracker

[Eric Anholt <eric@anholt.net>]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

Paul Kocialkowski <paul.kocialkowski@bootlin.com> writes:

> In order to test whether the load tracker is working as expected, we
> need the ability to compare the commit result with the underrun
> indication. With the load tracker always enabled, commits that are
> expected to trigger an underrun are always rejected, so userspace
> cannot get the actual underrun indication from the hardware.
>
> Add a debugfs entry to disable/enable the load tracker, so that a DRM
> commit expected to trigger an underrun can go through with the load
> tracker disabled. The underrun indication is then available to
> userspace and can be checked against the commit result with the load
> tracker enabled.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Given that the load tracker is going to be conservative and say things
will underrun even when they might not in practice, will this actually
be useful for automated testing?  Or is the intent to make it easier to
tune the load tracker by disabling it so that you can experiment freely?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]