public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Yury Norov <ynorov@caviumnetworks.com>, linux-kernel@vger.kernel.org
Cc: Yury Norov <ynorov@caviumnetworks.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Clement Courbet <courbet@google.com>,
	Matthew Wilcox <mawilcox@microsoft.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH] lib: test module for find_*_bit() functions
Date: Sun, 12 Nov 2017 22:33:55 +1100	[thread overview]
Message-ID: <87r2t3wx24.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20171109140714.13168-1-ynorov@caviumnetworks.com>

Yury Norov <ynorov@caviumnetworks.com> writes:

> find_bit functions are widely used in the kernel, including hot paths.
> This module tests performance of that functions in 2 typical scenarios:
> randomly filled bitmap with relatively equal distribution of set and
> cleared bits, and sparse bitmap which has 1 set bit for 500 cleared bits.
>
> On ThunderX machine:
>
> 		 Start testing find_bit() with random-filled bitmap
> [1032111.632383] find_next_bit:		240043 cycles,	164062 iterations
> [1032111.647236] find_next_zero_bit:	312848 cycles,	163619 iterations
> [1032111.661585] find_last_bit:		193748 cycles,	164062 iterations
> [1032113.450517] find_first_bit:	177720874 cycles,	164062 iterations
> [1032113.462930]
> 		 Start testing find_bit() with sparse bitmap
> [1032113.477229] find_next_bit:		3633 cycles,	656 iterations
> [1032113.494281] find_next_zero_bit:	620399 cycles,	327025 iterations
> [1032113.506723] find_last_bit:		3038 cycles,	656 iterations
> [1032113.524485] find_first_bit:	691407 cycles,	656 iterations

Have you thought about timing it rather than using get_cycles()?

get_cycles() has the downside that it can't be compared across different
architectures or even platforms within an architecture.

cheers

  parent reply	other threads:[~2017-11-12 11:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 14:07 [PATCH] lib: test module for find_*_bit() functions Yury Norov
2017-11-09 14:33 ` Clement Courbet
2017-11-09 23:15 ` Andrew Morton
2017-11-10 10:45   ` Alexey Dobriyan
2017-11-14 10:07     ` Yury Norov
2017-11-14 23:55       ` Andrew Morton
2017-11-12 11:33 ` Michael Ellerman [this message]
2017-11-14 10:58   ` Yury Norov
2017-11-21  8:38 ` Geert Uytterhoeven
2017-11-24 14:30   ` Yury Norov
2017-11-24 15:46     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2t3wx24.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=courbet@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mawilcox@microsoft.com \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox