From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v5] vfat: Deduplicate hex2bin()
Date: Tue, 01 Aug 2017 05:56:36 +0900 [thread overview]
Message-ID: <87r2wwtjej.fsf@devron> (raw)
In-Reply-To: <1501529949.29303.314.camel@linux.intel.com> (Andy Shevchenko's message of "Mon, 31 Jul 2017 22:39:09 +0300")
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>> > + fill = hex2bin(hc, ip + 1, 2);
>> > + if (fill)
>> > + return fill;
>>
>> This should not use random errno (in this case, it is -1 (EPERM)).
>
> You perhaps missed the side note I put after --- line.
> It reflects this change.
Sure, I missed to read it. But same here, hex2bin() doesn't care FS's
errno, it is what "random errno" I meant (I.e. hex2bin() might change it
to bool or any other errno again).
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2017-07-31 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 14:33 [PATCH v5] vfat: Deduplicate hex2bin() Andy Shevchenko
2017-07-31 18:40 ` OGAWA Hirofumi
2017-07-31 18:44 ` OGAWA Hirofumi
2017-07-31 19:31 ` Andy Shevchenko
2017-07-31 20:54 ` OGAWA Hirofumi
2017-08-01 12:56 ` Andy Shevchenko
2017-07-31 19:39 ` Andy Shevchenko
2017-07-31 20:56 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2wwtjej.fsf@devron \
--to=hirofumi@mail.parknet.co.jp \
--cc=andriy.shevchenko@linux.intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox