From: Felipe Balbi <balbi@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: gregkh@linuxfoundation.org, broonie@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
baolin.wang@linaro.org
Subject: Re: [PATCH v2] usb: dwc3: gadget: Wait for end transfer complete before free irq
Date: Thu, 13 Oct 2016 10:02:35 +0300 [thread overview]
Message-ID: <87r37kviic.fsf@linux.intel.com> (raw)
In-Reply-To: <d487de14326837b81af6a420a07173a7c0008bfc.1476272070.git.baolin.wang@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]
Hi,
Baolin Wang <baolin.wang@linaro.org> writes:
> @@ -1742,6 +1791,17 @@ static int dwc3_gadget_stop(struct usb_gadget *g)
> dwc->gadget_driver = NULL;
> spin_unlock_irqrestore(&dwc->lock, flags);
>
> + /*
> + * Since the xHCI will share the same interrupt with gadget, thus when
> + * free the gadget irq, it will not shutdown this gadget irq line. Then
> + * the gadget driver can not handle the end transfer command complete
> + * event after free the gadget irq, which will hang the system to crash.
> + *
> + * So we should wait for the end transfer command complete event before
> + * free it to avoid this situation.
> + */
> + dwc3_wait_command_complete(dwc);
this doesn't make sense. We have already masked all interrupts before
getting here. We have also, already, disabled all endpoints.
I'm thinking this is a bug in configfs interface of Gadget API, not
dwc3. The only reason for this to happen would be if we get to
->udc_stop() with endpoints still enabled.
Can you check if that's the case? i.e. can you check if any endpoints
are still enabled when we get here?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-10-13 7:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 11:37 [PATCH v2] usb: dwc3: gadget: Wait for end transfer complete before free irq Baolin Wang
2016-10-13 7:02 ` Felipe Balbi [this message]
2016-10-13 7:34 ` Baolin Wang
2016-10-13 7:51 ` Felipe Balbi
2016-10-13 8:00 ` Baolin Wang
2016-10-13 9:55 ` Felipe Balbi
2016-10-13 10:56 ` Felipe Balbi
2016-10-13 11:16 ` Baolin Wang
2016-10-13 11:23 ` Felipe Balbi
2016-10-13 12:41 ` Baolin Wang
2016-10-13 13:34 ` Felipe Balbi
2016-10-14 7:03 ` Baolin Wang
2016-10-14 7:46 ` Felipe Balbi
2016-10-14 9:10 ` Baolin Wang
2016-10-14 9:50 ` Felipe Balbi
2016-10-14 14:36 ` Alan Stern
2016-10-17 8:10 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r37kviic.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox