From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934216AbcIPLXK (ORCPT ); Fri, 16 Sep 2016 07:23:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51428 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755500AbcIPLXC (ORCPT ); Fri, 16 Sep 2016 07:23:02 -0400 From: Vitaly Kuznetsov To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, Haiyang Zhang Subject: Re: [PATCH v2 0/2] Drivers: hv: vmbus: make bus ids in sysfs persistent References: <1471989092-4190-1-git-send-email-vkuznets@redhat.com> Date: Fri, 16 Sep 2016 13:22:58 +0200 In-Reply-To: <1471989092-4190-1-git-send-email-vkuznets@redhat.com> (Vitaly Kuznetsov's message of "Tue, 23 Aug 2016 23:51:30 +0200") Message-ID: <87r38kxf59.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 16 Sep 2016 11:23:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vitaly Kuznetsov writes: > Bus ids for VMBus devices in /sys/bus/vmbus/devices/ are not guaranteed > to be persistent across reboot or kernel restart and this causes problems > for some tools. E.g. kexec tools use these ids to identify NIC on kdump. > Fix the issue by using if_instance from channel offer as the unique id > instead of an auto incremented counter. > > Changes since v1: > - Use if_instance instead of relid [K. Y. Srinivasan] > > Vitaly Kuznetsov (2): > Drivers: hv: make VMBus bus ids persistent > Drivers: hv: get rid of id in struct vmbus_channel > K. Y., I don't see these patches in your submissions to Greg. Could you please pick them up (in case there are no issues with them in your opinion, of course). Thanks! > drivers/hv/channel_mgmt.c | 2 -- > drivers/hv/vmbus_drv.c | 4 ++-- > include/linux/hyperv.h | 3 --- > 3 files changed, 2 insertions(+), 7 deletions(-) -- Vitaly