Re: [PATCH 5/9] tty: serial: jsm_tty: constify uart_ops structures

Gabriel Krisman Bertazi
2016-09-01T22:58:26Z

Julia Lawall <Julia.Lawall@lip6.fr> writes:

> Check for uart_ops structures that are only stored in the ops field of a
> uart_port structure. This field is declared const, so uart_ops structures
> that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct uart_ops i@p = { ... };
>
> @ok@
> identifier r.i;
> struct uart_port e;
> position p;
> @@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct uart_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct uart_ops i = { ... };
> // </smpl>
>

Acked-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>

--
Gabriel Krisman Bertazi