From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754379AbcHXJqr (ORCPT ); Wed, 24 Aug 2016 05:46:47 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35558 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752865AbcHXJqe (ORCPT ); Wed, 24 Aug 2016 05:46:34 -0400 From: Nicolai Stange To: Nicolai Stange Cc: Thomas Gleixner , John Stultz , linux-kernel@vger.kernel.org Subject: Re: [RFC v4 16/22] clockevents: use ->min_delta_ticks_adjusted to program minimum delta References: <20160822233320.4548-1-nicstange@gmail.com> <20160822233320.4548-17-nicstange@gmail.com> Date: Wed, 24 Aug 2016 11:28:29 +0200 In-Reply-To: <20160822233320.4548-17-nicstange@gmail.com> (Nicolai Stange's message of "Tue, 23 Aug 2016 01:33:14 +0200") Message-ID: <87r39eikhu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int clockevents_program_min_delta(struct clock_event_device *dev) > { > - unsigned long long clc; > - int64_t delta; > - > - delta = dev->min_delta_ns; > - > if (clockevent_state_shutdown(dev)) > return 0; > > dev->retries++; > - clc = ((unsigned long long) delta * dev->mult) >> dev->shift; > - return dev->set_next_event((unsigned long) clc, dev); > + return dev->set_next_event(dev->min_delta_ticks_incr, dev); > } > > #endif /* CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST */ FYI, the kernel build test robot reported a build failure with CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=n. It shoud read as dev->min_delta_ticks_adjusted here. In order to avoid unnecessary traffic, I'll only fix this up in a v5 if you give the whole thing a go.