public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* linux-next: build warning after merge of the virtio tree
@ 2015-03-13  4:31 Stephen Rothwell
  2015-03-13  5:22 ` Rusty Russell
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2015-03-13  4:31 UTC (permalink / raw)
  To: Rusty Russell, Michael S. Tsirkin; +Cc: linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

Hi Rusty,

After merging the virtio tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

net/9p/trans_virtio.c: In function 'p9_virtio_remove':
net/9p/trans_virtio.c:662:7: warning: unused variable 'inuse' [-Wunused-variable]
  bool inuse;
       ^

Introduced by commit 1991755689ad ("9p/trans_virtio: fix hot-unplug").

Some of the whitespace is mucked up in that commit as well (some
leading tabs, some leading spaces)
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: build warning after merge of the virtio tree
  2015-03-13  4:31 linux-next: build warning after merge of the virtio tree Stephen Rothwell
@ 2015-03-13  5:22 ` Rusty Russell
  0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2015-03-13  5:22 UTC (permalink / raw)
  To: Stephen Rothwell, Michael S. Tsirkin; +Cc: linux-next, linux-kernel

Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Rusty,
>
> After merging the virtio tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> net/9p/trans_virtio.c: In function 'p9_virtio_remove':
> net/9p/trans_virtio.c:662:7: warning: unused variable 'inuse' [-Wunused-variable]
>   bool inuse;
>        ^
>
> Introduced by commit 1991755689ad ("9p/trans_virtio: fix hot-unplug").
>
> Some of the whitespace is mucked up in that commit as well (some
> leading tabs, some leading spaces)

Hmm, I had a fix queued, but I'll just rebase and fix the whitespace
too.  And this:

WARNING: quoted string split across lines
#28: FILE: net/9p/trans_virtio.c:676:
+			dev_emerg(&vdev->dev, "p9_virtio_remove: "
+				  "waiting for device in use.\n");

Thanks,
Rusty.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-13  5:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-13  4:31 linux-next: build warning after merge of the virtio tree Stephen Rothwell
2015-03-13  5:22 ` Rusty Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox