From: ebiederm@xmission.com (Eric W. Biederman)
To: Changman Lee <cm224.lee@gmail.com>
Cc: 김재극 <jaegeuk.kim@samsung.com>, "Theodore Ts'o" <tytso@mit.edu>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
jooyoung.hwang@samsung.com, viro@zeniv.linux.org.uk,
chur.lee@samsung.com, cm224.lee@samsung.com
Subject: Re: [PATCH 10/16] f2fs: add core inode operations
Date: Mon, 08 Oct 2012 09:35:08 -0700 [thread overview]
Message-ID: <87r4p8gbwj.fsf@xmission.com> (raw)
In-Reply-To: <CAN863Pu_W4P74oQyJQnkXhUW+q-0zJR7F+gW_n6JqoOQOwG0ww@mail.gmail.com> (Changman Lee's message of "Mon, 8 Oct 2012 21:28:40 +0900")
Changman Lee <cm224.lee@gmail.com> writes:
>> > +void update_inode(struct inode *inode, struct page *node_page)
>> > +{
>> > + struct f2fs_node *rn;
>> > + struct f2fs_inode *ri;
>> > +
>> > + wait_on_page_writeback(node_page);
>> > +
>> > + rn = page_address(node_page);
>> > + ri = &(rn->i);
>> > +
>> > + ri->i_mode = cpu_to_le16(inode->i_mode);
>> > + ri->i_uid = cpu_to_le32(inode->i_uid);
>> > + ri->i_gid = cpu_to_le32(inode->i_gid);
>> And make this:
>> i_uid_write(inode, le32_to_cpu(ri->i_uid));
>> i_gid_write(inode, le32_to_cpu(ri->i_gid));
>>
>
> You mean this. Right? :)
> ri->i_uid = cpu_to_le32(i_uid_read(inode));
> ri->i_gid = cpu_to_le32(i_gid_read(inode));
Yeah. ;)
I did have that one backwards.
Eric
prev parent reply other threads:[~2012-10-08 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 12:02 [PATCH 10/16] f2fs: add core inode operations 김재극
2012-10-05 20:28 ` Eric W. Biederman
2012-10-06 18:06 ` Jaegeuk Kim
[not found] ` <CAN863Pu_W4P74oQyJQnkXhUW+q-0zJR7F+gW_n6JqoOQOwG0ww@mail.gmail.com>
2012-10-08 16:35 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4p8gbwj.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=chur.lee@samsung.com \
--cc=cm224.lee@gmail.com \
--cc=cm224.lee@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jaegeuk.kim@samsung.com \
--cc=jooyoung.hwang@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox