From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030327Ab2GLKNw (ORCPT ); Thu, 12 Jul 2012 06:13:52 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:44068 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933271Ab2GLKNs (ORCPT ); Thu, 12 Jul 2012 06:13:48 -0400 From: OGAWA Hirofumi To: Namjae Jeon Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Ravishankar N , Amit Sahrawat Subject: Re: [PATCH] fat: Support fallocate on fat. References: <1341716859-6768-1-git-send-email-linkinjeon@gmail.com> <87sjd2766n.fsf@devron.myhome.or.jp> <871uklp5j7.fsf@devron.myhome.or.jp> <87wr2dnp9r.fsf@devron.myhome.or.jp> Date: Thu, 12 Jul 2012 19:13:44 +0900 In-Reply-To: (Namjae Jeon's message of "Wed, 11 Jul 2012 13:22:31 +0900") Message-ID: <87r4shp9rb.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Namjae Jeon writes: >> I guess, if Windows truncates the above clusters than file size, it may >> be prefer to truncate on linux too. We really need it over umount? >> We never know the file whether corrupted or preallocated. >> >> And at least for now, it would be better to put under CONFIG_FAT_FALLOC >> or such, and warn it as unofficial way to preallocation on the >> explanation of CONFIG_FAT_FALLOC. >> >> Sorry, I'm still not reviewing the detail of code yet, like locking. And >> I'm still not convinced whether we should add this hack (unofficial way)... > Hi OGAWA. > Sorry for late response. > Currently I am looking for best solution for fallocate support. > next patch will be upated like the following. > 1. There is no security bug. > 2. Fix issue takes long time while preallocating. > 3. No compatibility issue. > Let' discuss after seeing next version's patch again. Sure, thanks. -- OGAWA Hirofumi