public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-pci: Use PCI MMIO instead of PIO when available
Date: Thu, 13 Oct 2011 10:22:36 +1030	[thread overview]
Message-ID: <87r52hepiz.fsf@rustcorp.com.au> (raw)
In-Reply-To: <4E950BDA.2040408@ozlabs.ru>

On Wed, 12 Oct 2011 14:39:06 +1100, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> Currently virtio-pci is specced so that configuration of the device is
> done through a PCI IO space (via BAR 0 of the virtual PCI device).
> However, use of PCI IO space (aka PIO) is long deprecated, and can be
> awkward to use on some systems (for example IBM pSeries machines
> typically have many PCI domains, and not all firmware/hypervisor
> versions necessarily support PCI PIO access on all domains).
> 
> Therefore, it would be preferable for the virtio virtual PCI device to
> advertise a PCI memory space (aka MMIO) BAR and have configuration
> done through this interface instead.  This can be done backwards
> compatibly by advertising the MMIO BAR in addition to the existing PIO
> BAR so that the guest driver can choose whichever interface.
> 
> In anticipation of adding such an MMIO BAR to virtio host-side
> implementations (e.g. qemu), this patch updates the Linux virtio-pci
> driver to attempt to use BAR 2 (which will be MMIO) in preference to
> the existing PIO BAR 0.

Applied.  Had to convert spaces to tabs though...

Thanks,
Rusty.

      reply	other threads:[~2011-10-13  0:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12  3:39 [PATCH] virtio-pci: Use PCI MMIO instead of PIO when available Alexey Kardashevskiy
2011-10-12 23:52 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r52hepiz.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=aik@ozlabs.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox