From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: Vitaly Mayatskikh <v.mayatskih@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: Fix OOPS in crash_kernel_shrink
Date: Tue, 20 Apr 2010 15:54:46 +0200 [thread overview]
Message-ID: <87r5maqleh.wl%vmayatsk@redhat.com> (raw)
In-Reply-To: <4BCDA46E.9030405@redhat.com>
At Tue, 20 Apr 2010 20:56:14 +0800, Cong Wang wrote:
>
> Vitaly Mayatskikh wrote:
> > Two "echo 0 > /sys/kernel/kexec_crash_size" OOPSes kernel. Also
> > content of this file is invalid after first shrink to zero: it shows 1
> > instead of 0.
> >
> > This patch fixes it.
>
> Hmmm, I certainly did tests for 'echo 0 > kexec_crash_size' when I
> worked on this, but I didn't get any oops. Can you show me the full
> oops?
Do it twice. start == end condition will work over and over, and
kernel will try to release_resource() again (and that's causes OOPS).
This scenario is unlikely to happen often (root privs, valid
crashkernel= in cmdline, dump-capture kernel not loaded), I hit it
only by chance.
--
wbr, Vitaly
next prev parent reply other threads:[~2010-04-20 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 13:21 Fix OOPS in crash_kernel_shrink Vitaly Mayatskikh
2010-04-20 12:56 ` Cong Wang
2010-04-20 13:54 ` Vitaly Mayatskikh [this message]
2010-04-22 8:30 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5maqleh.wl%vmayatsk@redhat.com \
--to=v.mayatskih@gmail.com \
--cc=amwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox