From: Don Mullis <don.mullis@gmail.com>
To: Olaf Titz <olaf@bigred.inka.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] lib: revise list_sort() comment
Date: Thu, 21 Jan 2010 20:54:07 -0800 [thread overview]
Message-ID: <87r5pi91u8.fsf@gmail.com> (raw)
In-Reply-To: <E1NY2R2-0007nJ-Ic@bigred.inka.de> (Olaf Titz's message of "Thu, 21 Jan 2010 20:11:16 +0100")
Olaf Titz <olaf@bigred.inka.de> writes:
>> + * The comparison function @cmp must return a negative value if @a
>> + * should sort before @b, and a positive value if @a should sort after
>> + * @b. If @a and @b are equivalent, and their original relative
>> + * ordering is to be preserved, @cmp should return 0; otherwise, the
>> + * return value does not matter.
>
> This "otherwise... does not matter" sounds funny and confusing. Either
> read this as "the return value does not matter if it is neither <0, >0
> or ==0" or "the return value does not matter if the function wants it
> to be ignored". :-)
>
> Just omitting the "otherwise" clause would be clearer.
>
> Olaf
Okay, I will simplify the wording.
next prev parent reply other threads:[~2010-01-22 4:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 4:51 [PATCH 1/2] lib: more scalable list_sort() Don Mullis
2010-01-21 5:17 ` [PATCH 2/2] lib: revise list_sort() comment Don Mullis
2010-01-21 19:11 ` Olaf Titz
2010-01-22 4:54 ` Don Mullis [this message]
2010-01-21 9:22 ` [PATCH 1/2] lib: more scalable list_sort() Artem Bityutskiy
2010-01-21 9:54 ` Dave Chinner
2010-01-21 11:44 ` Artem Bityutskiy
2010-01-21 16:34 ` Don Mullis
2010-01-21 17:59 ` Andi Kleen
2010-01-22 3:17 ` Don Mullis
2010-01-22 10:43 ` Andi Kleen
2010-01-22 12:29 ` Artem Bityutskiy
2010-01-22 17:55 ` Don Mullis
2010-01-23 8:28 ` Dave Chinner
2010-01-23 11:35 ` Andi Kleen
2010-01-23 16:05 ` Dave Chinner
2010-01-24 20:59 ` Andi Kleen
2010-01-24 21:10 ` Artem Bityutskiy
2010-01-24 22:38 ` Don Mullis
2010-01-25 3:41 ` Dave Chinner
2010-08-04 14:04 ` Artem Bityutskiy
2010-08-07 7:50 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5pi91u8.fsf@gmail.com \
--to=don.mullis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@bigred.inka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).