public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@saeurebad.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [patch 1/3] Rename WARN() to WARNING() to clear the namespace
Date: Wed, 07 May 2008 14:46:53 +0200	[thread overview]
Message-ID: <87r6cecmde.fsf@saeurebad.de> (raw)
In-Reply-To: <20080506232017.247001e0@infradead.org> (Arjan van de Ven's message of "Tue, 6 May 2008 23:20:17 -0700")

Hi Arjan,

Arjan van de Ven <arjan@infradead.org> writes:

> Subject: Rename WARN() to WARNING() to clear the namespace
> From: Arjan van de Ven <arjan@linux.intel.com>
>
> We want to use WARN() as a variant of WARN_ON(), however
> a few drivers are using WARN() internally. This patch renames
> these to WARNING() to avoid the namespace clash.
> A few cases were defining but not using the thing, for those
> cases I just deleted the definition.

It always bugged me that there is no WARN() that behaves similar to
BUG().

What do you think of making WARN() just emit the warning
unconditionally?

And maybe add the possibility to emit a text as well on both WARN() and
BUG()?  BUG("my kitten was hit by page %p!\n", page);

	Hannes

      parent reply	other threads:[~2008-05-07 12:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07  6:20 [patch 1/3] Rename WARN() to WARNING() to clear the namespace Arjan van de Ven
2008-05-07  6:21 ` [patch 2/3] Add a WARN() macro; this is WARN_ON() + printk arguments Arjan van de Ven
2008-05-07  6:21   ` [patch 3/3] Example use of WARN() Arjan van de Ven
2008-05-14  4:36     ` Andrew Morton
2008-05-14  4:51       ` Arjan van de Ven
2008-05-15  3:43       ` Arjan van de Ven
2008-05-07  6:41   ` [patch 2/3] Add a WARN() macro; this is WARN_ON() + printk arguments Vegard Nossum
2008-05-07 13:37     ` Arjan van de Ven
2008-05-07  7:31   ` Jiri Slaby
2008-05-07 12:46 ` Johannes Weiner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r6cecmde.fsf@saeurebad.de \
    --to=hannes@saeurebad.de \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox