From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: x86: improve default idle
Date: Mon, 21 Apr 2008 17:03:23 +0200 [thread overview]
Message-ID: <87r6cz6yis.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20080421142737.GU9554@elte.hu> (Ingo Molnar's message of "Mon, 21 Apr 2008 16:27:38 +0200")
Ingo Molnar <mingo@elte.hu> writes:
>
> sorry, the changelog should be: if a system uses acpi_pm clocksource but
> default idle method then the overhead of entry/exit measurement is quite
> noticeable in profiles. The measurement is redundant anyway, as in HLT
> sched_clock() is still supposed to work fine. (the worst i know of is a
> slight skew on certain CPUs in HLT)
sched_clock checks for unstable tsc so on all systems which mark
the TSC unstable at boot that will mean fall back to jiffies.
I'm not sure that will really work for them? It will be very imprecise.
Basically most of the time you'll have 0 delta and occasionally
every tick a huge jump.
For 64bit the idea of relying on TSC here is reasonable, but to make the code
behaviour really match your description you would first need another
sched_clock which ignores the normal tsc unstable state (the rewritten
sched_clock for which I posted links a few times recently did that)
On 32bit it would also need to take care of the few older CPUs
(like VIA C6) where TSC doesn't tick in C1.
-Andi
prev parent reply other threads:[~2008-04-21 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804181737.m3IHb2k7009676@hera.kernel.org>
2008-04-18 22:43 ` x86: improve default idle Andrew Morton
2008-04-21 14:27 ` Ingo Molnar
2008-04-21 15:03 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r6cz6yis.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox