* [PATCH] bttv winfast 2000 tuner type
@ 2004-11-04 5:18 John McCutchan
2004-11-04 9:27 ` Gerd Knorr
0 siblings, 1 reply; 2+ messages in thread
From: John McCutchan @ 2004-11-04 5:18 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
Trivial patch that lets you configure the tuner type of your winfast
2000 tuner card. The default value is the previous hard coded value.
--
John McCutchan <ttb@tentacle.dhs.org>
[-- Attachment #2: bttv-winfast-2000-tuner-type.diff --]
[-- Type: text/x-patch, Size: 1073 bytes --]
--- clean/linux/drivers/media/video/Kconfig 2004-10-18 17:55:18.000000000 -0400
+++ linux/drivers/media/video/Kconfig 2004-11-04 00:07:57.000000000 -0500
@@ -22,6 +22,18 @@
To compile this driver as a module, choose M here: the
module will be called bttv.
+config VIDEO_WINFAST2000_TUNER_TYPE
+ int "Leadtek WinFast 2000 tuner type"
+ depends on VIDEO_BT848
+ default 5
+ help
+ Selects the tuner type for the WinFast 2000 TV Tuner cards.
+
+ Known tuner types:
+
+ 5 - PAL
+ 2 - NTSC
+
config VIDEO_PMS
tristate "Mediavision Pro Movie Studio Video For Linux"
depends on VIDEO_DEV && ISA
--- clean/linux/drivers/media/video/bttv-cards.c 2004-10-18 17:54:08.000000000 -0400
+++ linux/drivers/media/video/bttv-cards.c 2004-11-04 00:11:25.000000000 -0500
@@ -794,7 +794,7 @@
.needs_tvaudio = 0,
.pll = PLL_28,
.has_radio = 1,
- .tuner_type = 5, // default for now, gpio reads BFFF06 for Pal bg+dk
+ .tuner_type = CONFIG_VIDEO_WINFAST2000_TUNER_TYPE,
.audio_hook = winfast2000_audio,
.has_remote = 1,
},{
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] bttv winfast 2000 tuner type
2004-11-04 5:18 [PATCH] bttv winfast 2000 tuner type John McCutchan
@ 2004-11-04 9:27 ` Gerd Knorr
0 siblings, 0 replies; 2+ messages in thread
From: Gerd Knorr @ 2004-11-04 9:27 UTC (permalink / raw)
To: John McCutchan; +Cc: linux-kernel
John McCutchan <ttb@tentacle.dhs.org> writes:
> Trivial patch that lets you configure the tuner type of your winfast
> 2000 tuner card. The default value is the previous hard coded value.
No. Compile time options are evil.
There is a insmod option for that (tuner=<nr>) since ages because that
is a common issue with tv cards that they are shipped with different
tuners in different regions of the world and it isn't allways known
how to figure which one actually is used.
Just put "option bttv tuner=whatever" into your modprobe.conf and be
done with it.
Gerd
--
#define printk(args...) fprintf(stderr, ## args)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-04 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-04 5:18 [PATCH] bttv winfast 2000 tuner type John McCutchan
2004-11-04 9:27 ` Gerd Knorr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox