From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F53F367B72 for ; Tue, 23 Jun 2026 14:08:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782223724; cv=none; b=kSh4je9S1xBCozrDp0PXDR01hz3kS3wdH46Y8ZbwK72F4PN2WN+RzVB4KD+EvRh+TRQ3Cp5RpqrIYSKIIRcA6FIKivLnAmyyaH1U8bESw3s9cV+C0QJ7GTZ4Rq1KPG9/w7eM8UjOxmpfNvKq1lcWXKsbx+UoIwzrGrAWnb9pxJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782223724; c=relaxed/simple; bh=CcrBod0NpInYPKoUb6JbufDvDcjMzHvFRnRxYd9I4nw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cvbkIOItBv6nuxtpklaO5hcUKHxWpNTGFZM3iThUlCYUoK2yl6nX26iIAZO9XNFTqE8O5yDjK0bcBdbkpCTGX/pHy3/9Tm1brI4leJj/O/sYDlsLC4x+NumoOzIK4nb+HtMpcIw8tzG/ny/L8yu95aIIDC34ruQRf5mzcALqvyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=IZuJTS4G; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="IZuJTS4G" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id C227F4E40769; Tue, 23 Jun 2026 14:08:39 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 910EB601C2; Tue, 23 Jun 2026 14:08:39 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8709C106C8382; Tue, 23 Jun 2026 16:08:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782223718; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=Tj/U0Y54eAKclejjEBVwWZyUPwiS6WzmvFTi1kYoa60=; b=IZuJTS4Gaj7zpjzOxVenDZXvDPqCUWMOEpXcEhfV25BRkcLbwZBK5o8Md0Sp0vUMh3/lI2 uNLYIaZKGKBzSO/ZwJzR858RhBjQKDKQEPaWRbsmXflsTjoZAiVlg6+AC3pkHQvzzhQc0U rL1fR+RYTXNHmNYaRzuu9sH5jtyXIP7egW5NXeTxl3/MnJgTsQbAWxlAFFxotrgYvz67jU 411GO7jLeSEFDZ/KCW6wJSRJLR0pgWW3cAhnC8rh9Jcag4K9lL5hQ9HsnYXiHFEhpiANYe slL4Wku8V2rEdhkYnNYIfWvqbhiYUzn/Wr/453FOhGPqOrsfXNsYNAGo7UFPqA== From: Miquel Raynal To: Pengpeng Hou Cc: Richard Weinberger , Vignesh Raghavendra , Matthias Brugger , AngeloGioacchino Del Regno , Jorge Ramirez-Ortiz , Boris Brezillon , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] mtd: nand: mtk-ecc: stop on ECC idle timeouts In-Reply-To: <20260623135729.52304-1-pengpeng@iscas.ac.cn> (Pengpeng Hou's message of "Tue, 23 Jun 2026 21:57:29 +0800") References: <20260623135729.52304-1-pengpeng@iscas.ac.cn> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 23 Jun 2026 16:08:34 +0200 Message-ID: <87se6dmjrx.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Last-TLS-Session-Version: TLSv1.3 Hello, > diff --git a/drivers/mtd/nand/ecc-mtk.c b/drivers/mtd/nand/ecc-mtk.c > index c75bb8b80..96703f0a4 100644 > --- a/drivers/mtd/nand/ecc-mtk.c > +++ b/drivers/mtd/nand/ecc-mtk.c > @@ -123,8 +123,8 @@ static int mt7622_ecc_regs[] = { > [ECC_DECIRQ_STA] = 0x144, > }; > > -static inline void mtk_ecc_wait_idle(struct mtk_ecc *ecc, > - enum mtk_ecc_operation op) > +static inline int mtk_ecc_wait_idle(struct mtk_ecc *ecc, > + enum mtk_ecc_operation op) Looks good, but could you follow up with a patch which removes the inline keyword as well? It does not seem to serve any purpose there.