The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctxfi: Keep line/mic notification controls per mixer
Date: Mon, 18 May 2026 15:43:55 +0200	[thread overview]
Message-ID: <87se7o4yuc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260517-alsa-ctxfi-mixer-kctls-v1-1-6e4f81f6b658@gmail.com>

On Mon, 18 May 2026 04:33:49 +0200,
Cássio Gabriel wrote:
> 
> ctxfi stores the Line Capture Switch and Mic Capture Switch controls in
> a file-scope kctls[] array so do_line_mic_switch() can notify the
> opposite control when the shared line/mic input selection changes.
> 
> That storage is shared by all ctxfi cards. If more than one X-Fi card is
> present, a later card can overwrite the pointers saved by an earlier one.
> A control update on one card can then use another card's kcontrol object
> for snd_ctl_notify(). If that other card is removed, the saved pointer can
> also become stale.
> 
> Store those notification targets in struct ct_mixer instead. The mixer is
> per-card state and matches the lifetime of the controls created for that
> card.
> 
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-05-18 13:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18  2:33 [PATCH] ALSA: ctxfi: Keep line/mic notification controls per mixer Cássio Gabriel
2026-05-18 13:43 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87se7o4yuc.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cassiogabrielcontato@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox