From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 184CA3644CB for ; Mon, 16 Mar 2026 21:15:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773695703; cv=none; b=P/c9/nRcxFJ85MZtFZIrQco7srJoJOL7WJ2J7Gs241562XvPN8IcZ5hU9Dw83XIIJqaSh4Vj+0aEPLnFHYFtkqlomRsrtaAL3MCN3ocPsjX8meQrMWzS6jDa+Q3jALrRymPFdrvPlNylIJOCbEq/V2wPHNJoMuZnJlFbP/+GB4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773695703; c=relaxed/simple; bh=0Oj+Hg0COk5k4E77Dw+rDNrDW1M8r84BWy9CKd3O7So=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ti4oqli+o9usqsv4Y/KnxPfGwe5NPE84cI1Q2IqpSX1eAJ7mUtjEj9ccGBxn4tox3OBK6I2GrD9McgygYPKB4RmqdrGDXMEQBK0ZtGcR829nsiIA4NibvWbQqXgfk4ON9i+inG2kmVSI2gnIGZD9J6pRaFp/tknjZnlgOAfF4Jg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tY9IvTl+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tY9IvTl+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3370C19424; Mon, 16 Mar 2026 21:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773695702; bh=0Oj+Hg0COk5k4E77Dw+rDNrDW1M8r84BWy9CKd3O7So=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tY9IvTl+NCGSbLufR/yVGN8Y7PklHbqsYCKgF4fXWI37yNERQR6yDM9AKjQCyqSmT TNKEMISb/zwbebJjv1+RG1Vjyz1hrqh4anidnsbGJz2zBketMXilvfCuf02BfyMCaE jRemchIgFot7OAp2PfVDZudqd9eOb2BkEohTjL+7xcpARnPKOnJrvXgSTjryxVQsMt VyuepjtUmbSbYpohzwz61tYhNjC8TtDocNMg/9g4/zXGBvVKHWCbhlav34QMmSSB3D 5oo4Uhk4u/VgA9GN4JUKVBIEUmuRgWNPk38rzbWJ8DIDP8aluQLkClKBFXthGiWVxa WmD5XYDECw0JQ== From: Thomas Gleixner To: Mathieu Desnoyers , LKML Cc: =?utf-8?Q?Andr=C3=A9?= Almeida , Sebastian Andrzej Siewior , Carlos O'Donell , Peter Zijlstra , Florian Weimer , Rich Felker , Torvald Riegel , Darren Hart , Ingo Molnar , Davidlohr Bueso , Arnd Bergmann , "Liam R . Howlett" Subject: Re: [patch 8/8] x86/vdso: Implement __vdso_futex_robust_try_unlock() In-Reply-To: <7b942738-231b-4168-8d97-0e5c974af2e9@efficios.com> References: <20260316162316.356674433@kernel.org> <20260316164951.484640267@kernel.org> <7b942738-231b-4168-8d97-0e5c974af2e9@efficios.com> Date: Mon, 16 Mar 2026 22:14:58 +0100 Message-ID: <87se9zo4rx.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Mar 16 2026 at 15:19, Mathieu Desnoyers wrote: >> +uint32_t __vdso_futex_robust_try_unlock(uint32_t *lock, uint32_t tid, void *pop) > > I'm not sure I see the link between "list_pending_op" and @pop ? What so hard to understand about that? The function prototype in include/vdso/futex.h is extensively documented. > [...] >> + : [tid] "+a" (tid) > > Could use a few comments: > > - "tid" sits in eax. If someone needs a comment to understand the constraint, then that persone definitely should not touch the code. I'm all for documentation and comments, but documenting the obvious is not useful at all. See: https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#comment-style I'm amazed that you complain about these obvious details and not about the actual lack of a general comment which explains the actual inner workings of that ASM maze. That would be actually useful for a unexperienced reader. Interesting preference. Thanks, tglx