From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F8C372EF4 for ; Tue, 3 Mar 2026 15:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772552878; cv=none; b=U1llCMwAyJFEP9YchAdR45tBsfoaS+2X2EOYSO1jtoTOD3hWbTGkdFy92TYTyr54oFFDIg2/RH5hsgXbOsoZGneauvVBC8aSUheKfh3siUpdaWBCd4b6Stp75Hsuyk1xNkDMNFPInITHlNvST99kWtd5CMH1lRqlTvNEj0LWGsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772552878; c=relaxed/simple; bh=SwizLDbjFGtmTfsljXMyUDSSNywCg292AfL6ZmR1k2s=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=e8cqDiJnSdit54q15MW844z6PJNNevEqEtgpt7ZIBI2w4UASeZEghJKiuPcLrMoq5tu3vjJWAb/lkaCbm6u1C7PAUkMA/agFzH1Qrs5AYA+Gd9kIuMtRGXuNYLpnbOlpLM6sKL2y6nf29kgL34zmuOc8qlkC2qKAawAepIuwOR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=iXSTN5kK; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=orpb1Kh6; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=iXSTN5kK; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=orpb1Kh6; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="iXSTN5kK"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="orpb1Kh6"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="iXSTN5kK"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="orpb1Kh6" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 899895BE0C; Tue, 3 Mar 2026 15:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772552875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3QuPsJYCuHIhEizr6kPqW6TAwPlDcT9J+GeBDrMRnBs=; b=iXSTN5kKITztVCs2pQbYgo5xCGMxJoLsSDvh2iapYK8fyc3tllO3ZWvkhr2HwqMPzk8W/7 UxudAayEhULjGfZ4FdFMHjj1FnMCJL9oZVaTICRR3CbqftkbhgiQpFzwjBP7dJBzd6HJw/ Sy5cnu0n3NGuSMHz9OivluzAYrA5eQE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772552875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3QuPsJYCuHIhEizr6kPqW6TAwPlDcT9J+GeBDrMRnBs=; b=orpb1Kh6ytDy4AlVrh/FK8ua6S/UGrkGIvUh3LJsrV0UImdxz6n+agdbQnJAqwwsapUEh4 GLCymNAXauhW0uBQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=iXSTN5kK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=orpb1Kh6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772552875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3QuPsJYCuHIhEizr6kPqW6TAwPlDcT9J+GeBDrMRnBs=; b=iXSTN5kKITztVCs2pQbYgo5xCGMxJoLsSDvh2iapYK8fyc3tllO3ZWvkhr2HwqMPzk8W/7 UxudAayEhULjGfZ4FdFMHjj1FnMCJL9oZVaTICRR3CbqftkbhgiQpFzwjBP7dJBzd6HJw/ Sy5cnu0n3NGuSMHz9OivluzAYrA5eQE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772552875; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3QuPsJYCuHIhEizr6kPqW6TAwPlDcT9J+GeBDrMRnBs=; b=orpb1Kh6ytDy4AlVrh/FK8ua6S/UGrkGIvUh3LJsrV0UImdxz6n+agdbQnJAqwwsapUEh4 GLCymNAXauhW0uBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6DEAB3EA69; Tue, 3 Mar 2026 15:47:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xzIuGqsCp2l0YwAAD6G6ig (envelope-from ); Tue, 03 Mar 2026 15:47:55 +0000 Date: Tue, 03 Mar 2026 16:47:55 +0100 Message-ID: <87seagx6c4.wl-tiwai@suse.de> From: Takashi Iwai To: Maciej Strozek Cc: Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 2/2] ALSA: control: add ioctl to retrieve full card components In-Reply-To: <20260303145815.9930-2-mstrozek@opensource.cirrus.com> References: <20260303145815.9930-1-mstrozek@opensource.cirrus.com> <20260303145815.9930-2-mstrozek@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.com:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 899895BE0C X-Spam-Flag: NO X-Spam-Score: -3.51 X-Spam-Level: On Tue, 03 Mar 2026 15:58:00 +0100, Maciej Strozek wrote: > > The fixed-size components field in SNDRV_CTL_IOCTL_CARD_INFO can be too > small on systems with many audio devices. > > Keep the existing struct snd_ctl_card_info ABI intact and add a new ioctl > to retrieve the full components string. > > When the legacy components field is truncated, append '>' to indicate > that the full string is available via the new ioctl. > > Link: https://github.com/alsa-project/alsa-lib/pull/494 > Suggested-by: Jaroslav Kysela > Suggested-by: Takashi Iwai > Signed-off-by: Maciej Strozek > --- > Changes for v3: > - change components field to a dynamic array resizable in 32 byte increments > - removed SNDRV_CTL_COMPONENTS_LEN define > - sanity check if 'components' requests more than 512 bytes > - added a commit to clean up trailing whitespaces > - alsa-utils link no longer needed > Changes for v2: > - do not modify existing card->components field > - add a new ioctl and struct to keep the full components string > - handle the split/trim in snd_ctl_card_info() > --- > include/sound/core.h | 4 ++-- > include/uapi/sound/asound.h | 14 ++++++++++++- > sound/core/control.c | 35 ++++++++++++++++++++++++++++++++- > sound/core/control_compat.c | 2 ++ > sound/core/init.c | 39 +++++++++++++++++++++++++++++-------- > 5 files changed, 82 insertions(+), 12 deletions(-) > > diff --git a/include/sound/core.h b/include/sound/core.h > index 4093ec82a0a1..2b58f79b524d 100644 > --- a/include/sound/core.h > +++ b/include/sound/core.h > @@ -87,8 +87,8 @@ struct snd_card { > char longname[80]; /* name of this soundcard */ > char irq_descr[32]; /* Interrupt description */ > char mixername[80]; /* mixer name */ > - char components[128]; /* card components delimited with > - space */ > + char *components_ptr; > + unsigned int components_ptr_alloc_size; // current memory allocation components_ptr. > struct module *module; /* top-level module */ > > void *private_data; /* private data for soundcard */ > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h > index d3ce75ba938a..422b0b07613d 100644 > --- a/include/uapi/sound/asound.h > +++ b/include/uapi/sound/asound.h > @@ -1058,7 +1058,7 @@ struct snd_timer_tread { > * * > ****************************************************************************/ > > -#define SNDRV_CTL_VERSION SNDRV_PROTOCOL_VERSION(2, 0, 9) > +#define SNDRV_CTL_VERSION SNDRV_PROTOCOL_VERSION(2, 0, 10) > > struct snd_ctl_card_info { > int card; /* card number */ > @@ -1072,6 +1072,17 @@ struct snd_ctl_card_info { > unsigned char components[128]; /* card components / fine identification, delimited with one space (AC97 etc..) */ > }; > > +/* > + * Card components can exceed the fixed 128 bytes in snd_ctl_card_info. > + * Use SNDRV_CTL_IOCTL_CARD_COMPONENTS to retrieve the full string. > + * > + */ > +struct snd_ctl_card_components { > + int card; > + unsigned int length; > + unsigned char *components; > +}; Embedding a pointer for ioctl is a nightmare for 32bit compatibility, and you seem to have forgotten it, too ;) IMO, in this case, it'd be easier to use a flex array instead, e.g. struct snd_ctl_card_components { int card; unsigned int length; unsigned char components[]; }; And the ioctl can serve for two purposes: - When length=0 is set, the kernel stores the current number of bytes and returns without copying. User-space can use this mode for allocating the buffer. - When length > 0 is set, the kernel copies the data on components[] up to the given length. The length field is updated again to store the number of bytes (which would be copied). What this length field specifies is another question: is it a string length or a buffer length including NUL? Also, we can keep the current string size, too, for returning in the sequence in the above, instead of doing strlen() at each time. thanks, Takashi