From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2001C2AD37; Sat, 7 Feb 2026 12:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770468047; cv=none; b=n6BPk//Q9hN3bfru/mIiCsTP7njRyKIuPdAXQAfFtyz8dMEi1+jSSg9xMsI8nSVts4FPV4qKHGJGJ20myyWiyiTyyD1TLvsp2hdWf+ikM3hDOVTXdUcADGhjAlZpDxfAJfzMAc7ThyMKSvmr15p9OI4SFP0OBTfagIqHZAMFiVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770468047; c=relaxed/simple; bh=KOORmID8yt4Yoxy3qIraV6R3a0xDi89MMWmjlOPviZA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=fMBLc00mXfdXRHuNPiBrs9XvEAhNJIHthbUgBgOOd94tp1mhiuHf8N57g5xNuYclOkiEO7v+rQBKxlSRGyugoUr6pCcKI7/eQFlEHqwpDiFIAQ0vnuDhmIdQd4El6k0wyd8g2WkWtkP10Z+J85NOgk+5kiAEP/2jdXrC2v90ny4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=IHUEfbEs; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=QRPaRJuX; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="IHUEfbEs"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="QRPaRJuX" From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1770468039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u7mw2REIi5YvReIN1++C/n4doj/HVhTauIRAe2doeMY=; b=IHUEfbEs7jatAyG0QJUXYH7tn0JLEYfYurUxGzjGRBE5e/M9QAME/qZ7DMNVU5XfxXe65N f9JmkBPSVMEEpywPQHJlcAHkoea0xia8FeK1YwmlHfg5SM/Q69haYUN/oIIUq+Y8TIifmg O1e3UdPaw/6WwgB9BH2nDW+Vv8ZvdQ/NXAoAZ9GOBi1KpVg7uenYmJ+o77Dm4KJYRxK0a2 hD3R0XP6AmRTUpJIa+Fer1KHRIazZqiquew3rMZdN9FUwaTMu4Zwy0B3g2rFqAi8JxlzDr YYYivOb1WjwDFuNz/lLzSxgeOyDgRBipZqqfA/B5NakR621s/EYifdFxOZzDZA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1770468039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u7mw2REIi5YvReIN1++C/n4doj/HVhTauIRAe2doeMY=; b=QRPaRJuX/plnEzL6PBt2E45uECSGwK6YLL3plNVB/bNviWky8Y5y7+9Uu94qN9CMnFSj6E XRbiA86rYYsGjXAA== To: Ryan Chen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" Subject: RE: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1 support In-Reply-To: References: <20260205-irqchip-v1-0-b0310e06c087@aspeedtech.com> <20260205-irqchip-v1-2-b0310e06c087@aspeedtech.com> <87h5ru14xx.ffs@tglx> Date: Sat, 07 Feb 2026 13:40:38 +0100 Message-ID: <87sebczpyx.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sat, Feb 07 2026 at 03:50, Ryan Chen wrote: >> -----Original Message----- >> From: Thomas Gleixner >> Sent: Friday, February 6, 2026 7:34 PM >> To: Ryan Chen ; Rob Herring ; >> Krzysztof Kozlowski ; Conor Dooley >> ; Joel Stanley ; Andrew Jeffery >> ; Paul Walmsley ; Palmer >> Dabbelt ; Albert Ou ; >> Alexandre Ghiti >> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; >> linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; >> linux-riscv@lists.infradead.org; Ryan Chen >> Subject: Re: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1 >> support Please fix your email client to not copy all mail headers. If you can't fix it, remove them manually and replace it with the usual: On Fri, Feb 06 2026 at ...., Thomas Gleixner wrote: >> > + guard(raw_spinlock_irqsave)(&intc0->intc_lock); >> >> s/_irqsave// Interrupts are disabled when this is invoked. > Sorry, do you mean when this function been call. > Ther have desc->lock to do the raw_spin_lock_irqsave. The core always holds irq_desc::lock with interrupts disabled when it invokes those irqchip callbacks. So trying to disable interrupts in them again is a pointless exercise.