public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v1 1/1] kernel-doc: Issue warnings that were silently discarded
Date: Wed, 05 Nov 2025 11:12:18 -0700	[thread overview]
Message-ID: <87sees73i5.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20251104215502.1049817-1-andriy.shevchenko@linux.intel.com>

[Heads up to Stephen: this change will add a bunch of warnings that had
been dropped before.]

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> When kernel-doc parses the sections for the documentation some errors
> may occur. In many cases the warning is simply stored to the current
> "entry" object. However, in the most of such cases this object gets
> discarded and there is no way for the output engine to even know about
> that. To avoid that, check if the "entry" is going to be discarded and
> if there warnings have been collected, issue them to the current logger
> as is and then flush the "entry". This fixes the problem that original
> Perl implementation doesn't have.

I would really like to redo how some of that logging is done, but that
is an exercise for another day.  For now, I have applied this one,
thanks.

jon

  parent reply	other threads:[~2025-11-05 18:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 21:55 [PATCH v1 1/1] kernel-doc: Issue warnings that were silently discarded Andy Shevchenko
2025-11-04 23:14 ` kernel test robot
2025-11-05  5:26   ` Andy Shevchenko
2025-11-04 23:14 ` kernel test robot
2025-11-05  5:27   ` Andy Shevchenko
2025-11-05  7:48     ` Philip Li
2025-11-05 10:02       ` Andy Shevchenko
2025-11-05 12:02         ` Philip Li
2025-11-04 23:18 ` Randy Dunlap
2025-11-05  6:38   ` Andy Shevchenko
2025-11-05 18:12 ` Jonathan Corbet [this message]
2025-11-05 18:51   ` Andy Shevchenko
2025-11-09  0:03   ` Randy Dunlap
2025-11-09 15:54     ` Andy Shevchenko
2025-11-09 20:34       ` Randy Dunlap
2025-11-05 21:19 ` Mauro Carvalho Chehab
2025-11-06  0:48   ` Randy Dunlap
2025-11-06  7:31   ` Andy Shevchenko
2025-11-06  7:42     ` Andy Shevchenko
2025-11-06 13:12     ` Mauro Carvalho Chehab
     [not found] ` <202511060602.1xDZ7cIT-lkp@intel.com>
2025-11-06  7:23   ` [BUILD REGRESSION] LAST PATCH: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sees73i5.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox