* [PATCH -next] genirq/timings: Use time_after_eq() macro
@ 2024-09-02 2:57 Jinjie Ruan
2024-09-08 14:06 ` Thomas Gleixner
0 siblings, 1 reply; 2+ messages in thread
From: Jinjie Ruan @ 2024-09-02 2:57 UTC (permalink / raw)
To: tglx, linux-kernel; +Cc: ruanjinjie
Use time_after_eq() macro instead of directly handling it.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
kernel/irq/timings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index 69f103b4c7a6..a96c0f1346fd 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -383,7 +383,7 @@ static u64 __irq_timings_next_event(struct irqt_stat *irqs, int irq, u64 now)
{
int index, i, period_max, count, start, min = INT_MAX;
- if ((now - irqs->last_ts) >= NSEC_PER_SEC) {
+ if (time_after_eq(now, irqs->last_ts + NSEC_PER_SEC)) {
irqs->count = irqs->last_ts = 0;
return U64_MAX;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] genirq/timings: Use time_after_eq() macro
2024-09-02 2:57 [PATCH -next] genirq/timings: Use time_after_eq() macro Jinjie Ruan
@ 2024-09-08 14:06 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2024-09-08 14:06 UTC (permalink / raw)
To: Jinjie Ruan, linux-kernel; +Cc: ruanjinjie
On Mon, Sep 02 2024 at 10:57, Jinjie Ruan wrote:
> @@ -383,7 +383,7 @@ static u64 __irq_timings_next_event(struct irqt_stat *irqs, int irq, u64 now)
> {
> int index, i, period_max, count, start, min = INT_MAX;
>
> - if ((now - irqs->last_ts) >= NSEC_PER_SEC) {
> + if (time_after_eq(now, irqs->last_ts + NSEC_PER_SEC)) {
time_after_eq() is meant for handling jiffies and not for arbitraty time
stamps which have nothing to do with jiffies at all
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-08 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02 2:57 [PATCH -next] genirq/timings: Use time_after_eq() macro Jinjie Ruan
2024-09-08 14:06 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox