From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-4022.proton.ch (mail-4022.proton.ch [185.70.40.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF0C525760 for ; Wed, 28 Aug 2024 03:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.22 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816605; cv=none; b=I15VIFmwy5Ysz3h42fmF34phNwLUhIkEQlU3ry50xHaXw7RwinPw+skdIIk5zwn+n/UAcSSyqsgwgiaSWuN6RKUW7JX2bDXiTwb/oShQBeC7nKbmJoNH7wY3/QNH1j98YaKOMIOcVD39a+CXfYhfqEJzXTnmJxXznyseU0GYUuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724816605; c=relaxed/simple; bh=6/tylI2FvjNZ0x65xJzqgWbbSYIr7+H9PBrABl03S3s=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=q4ry1puov3GcWPHSiuN4iYV9ZW4j8uPIjeflxDWbBTIPCmgdKgd3ygM4WFFSIgF/Xl/xiSgsYdswspSIYAPFuaFqpLhnMIp90CBaf+8k3ArJwB/Gw03Jy3fBKHFHlEZRsQ5MEGl6s3LnKYO96aH5YwrDZQjL4NCHJNcX2pF69EE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=metaspace.dk; spf=pass smtp.mailfrom=metaspace.dk; dkim=pass (2048-bit key) header.d=metaspace.dk header.i=@metaspace.dk header.b=Zk8mHozu; arc=none smtp.client-ip=185.70.40.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=metaspace.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=metaspace.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=metaspace.dk header.i=@metaspace.dk header.b="Zk8mHozu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=metaspace.dk; s=protonmail; t=1724816597; x=1725075797; bh=6/tylI2FvjNZ0x65xJzqgWbbSYIr7+H9PBrABl03S3s=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Zk8mHozuVT48dUkZlSzOOzk9Z+HxPaXT9QwcJnNO4LNxebAjxL3xoCVTaqNhCqA6A l/5cgj7gEjPfAH5IraGD6l/bkGyb9tzQvvinEmymG/5JC6wx1VMTBXpPqN4Ow6JAsf eWyUKjSZL4ryaUIf6q6rj7XwFZ6jzCR6+9mECUA7tRChYeEgw1d31XzEUq4iUn/O7l OjTRyZa9eLosPU9pSL9wplCb7xGQz/I8AXgshV0AViD7c/izEnRlZBlXPE10KFrnwb IgUowEklqwt1OOfoqeaGW3GvUfiUYCaLZHyNJIjE1GyqzYEtT2thlbt8HiPGMmEaNi cNsi+gWrcvErw== Date: Wed, 28 Aug 2024 03:43:10 +0000 To: Trevor Gross From: Andreas Hindborg Cc: Luis Chamberlain , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Andreas Hindborg , Adam Bratschi-Kaye , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Daniel Gomez , rust-for-linux@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] rust: add `module_params` macro Message-ID: <87seupwbwe.fsf@metaspace.dk> In-Reply-To: References: <20240819133345.3438739-1-nmi@metaspace.dk> <875xrmxdzg.fsf@metaspace.dk> Feedback-ID: 113830118:user:proton X-Pm-Message-ID: f538f8390aaa0b57d7575c91ccf1865765f47b95 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Trevor Gross" writes: > On Tue, Aug 27, 2024 at 10:00=E2=80=AFAM Andreas Hindborg wrote: >> >> "Trevor Gross" writes: >> >> > On Mon, Aug 19, 2024 at 8:35=E2=80=AFAM Andreas Hindborg wrote: >> >> >> >> From: Andreas Hindborg >> >> >> >> This patch includes changes required for Rust kernel modules to utili= ze >> >> module parameters. This code implements read only support for integer >> >> types without `sysfs` support. >> > >> > Also, I think the subject line needs an update ("rust: add >> > `module_params` macro") >> >> Well, it is still what it does. Plus few support types. You think it is >> not descriptive enough? > > Maybe it should just say 'Add parameter support to the `module!` > macro'? The text `module_params` doesn't seem to appear in the patch, > I was looking for something like `module_params!`. Right, I'll change it. BR Andreas