public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Parsa Poorshikhian <parsa.poorsh@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	tiwai@suse.com, kailang@realtek.com
Subject: Re: [PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7
Date: Sun, 11 Aug 2024 10:18:20 +0200	[thread overview]
Message-ID: <87sevbjwvn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240810150939.330693-1-parsa.poorsh@gmail.com>

On Sat, 10 Aug 2024 17:09:06 +0200,
Parsa Poorshikhian wrote:
> 
> Fixes: 70794b9563fe ("ALSA: hda/realtek: Add more codec ID to no shutup pins list")

The Fixes tag should be around Signed-off-by tag.

> Fix noise from speakers connected to AUX port when no sound is playing.
> The problem occurs because the `alc_shutup_pins` function includes
> a 0x10ec0257 vendor ID, which causes noise on Lenovo IdeaPad 3 15IAU7 with
> Realtek ALC257 codec when no sound is playing.
> Removing this vendor ID from the function fixes the bug.
> 
> Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com>

Applied with a minor modification above.  Thanks!


Takashi

  reply	other threads:[~2024-08-11  8:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-10 15:09 [PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7 Parsa Poorshikhian
2024-08-11  8:18 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-08-09 18:12 Parsa Poorshikhian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sevbjwvn.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=parsa.poorsh@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox