* [PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7
@ 2024-08-10 15:09 Parsa Poorshikhian
2024-08-11 8:18 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Parsa Poorshikhian @ 2024-08-10 15:09 UTC (permalink / raw)
To: linux-kernel; +Cc: Parsa Poorshikhian, linux-sound, tiwai, kailang
Fixes: 70794b9563fe ("ALSA: hda/realtek: Add more codec ID to no shutup pins list")
Fix noise from speakers connected to AUX port when no sound is playing.
The problem occurs because the `alc_shutup_pins` function includes
a 0x10ec0257 vendor ID, which causes noise on Lenovo IdeaPad 3 15IAU7 with
Realtek ALC257 codec when no sound is playing.
Removing this vendor ID from the function fixes the bug.
Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e2dbcf8f5bcf..7b593642da99 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -583,7 +583,6 @@ static void alc_shutup_pins(struct hda_codec *codec)
switch (codec->core.vendor_id) {
case 0x10ec0236:
case 0x10ec0256:
- case 0x10ec0257:
case 0x19e58326:
case 0x10ec0283:
case 0x10ec0285:
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7
2024-08-10 15:09 [PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7 Parsa Poorshikhian
@ 2024-08-11 8:18 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2024-08-11 8:18 UTC (permalink / raw)
To: Parsa Poorshikhian; +Cc: linux-kernel, linux-sound, tiwai, kailang
On Sat, 10 Aug 2024 17:09:06 +0200,
Parsa Poorshikhian wrote:
>
> Fixes: 70794b9563fe ("ALSA: hda/realtek: Add more codec ID to no shutup pins list")
The Fixes tag should be around Signed-off-by tag.
> Fix noise from speakers connected to AUX port when no sound is playing.
> The problem occurs because the `alc_shutup_pins` function includes
> a 0x10ec0257 vendor ID, which causes noise on Lenovo IdeaPad 3 15IAU7 with
> Realtek ALC257 codec when no sound is playing.
> Removing this vendor ID from the function fixes the bug.
>
> Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com>
Applied with a minor modification above. Thanks!
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7
@ 2024-08-09 18:12 Parsa Poorshikhian
0 siblings, 0 replies; 3+ messages in thread
From: Parsa Poorshikhian @ 2024-08-09 18:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Parsa Poorshikhian
Fixes: 70794b9563fe ("ALSA: hda/realtek: Add more codec ID to no shutup pins list")
Fix noise from speakers connected to AUX port when no sound is playing.
The problem occurs because the `alc_shutup_pins` function includes
a 0x10ec0257 vendor ID, which causes noise on Lenovo IdeaPad 3 15IAU7 with
Realtek ALC257 codec when no sound is playing.
Removing this vendor ID from the function fixes the bug.
Signed-off-by: Parsa Poorshikhian <parsa.poorsh@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e2dbcf8f5bcf..7b593642da99 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -583,7 +583,6 @@ static void alc_shutup_pins(struct hda_codec *codec)
switch (codec->core.vendor_id) {
case 0x10ec0236:
case 0x10ec0256:
- case 0x10ec0257:
case 0x19e58326:
case 0x10ec0283:
case 0x10ec0285:
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-11 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-10 15:09 [PATCH] ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7 Parsa Poorshikhian
2024-08-11 8:18 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2024-08-09 18:12 Parsa Poorshikhian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox