public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Guo Xuenan <guoxuenan@huawei.com>, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, guoxuenan@huawei.com,
	guoxuenan@huaweicloud.com, jack.qiu@huawei.com,
	ganjie5@huawei.com
Subject: Re: [PATCH] Documentation: dontdiff: remove 'utf8data.h'
Date: Thu, 08 Aug 2024 07:17:35 -0600	[thread overview]
Message-ID: <87sevfp30w.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20240808085707.3235019-1-guoxuenan@huawei.com>

Guo Xuenan <guoxuenan@huawei.com> writes:

> From: ganjie <ganjie5@huawei.com>
>
> Commit 2b3d04787012 ("unicode: Add utf8-data module") changed the
> database file from 'utf8data.h' to 'utf8data.c' to build separate
> module, but it seems forgot to update Documentation/dontdiff. Remove
> 'utf8data.h' and add 'utf8data.c'.
>
> Signed-off-by: ganjie <ganjie5@huawei.com>
> ---
>  Documentation/dontdiff | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/dontdiff b/Documentation/dontdiff
> index 3c399f132e2d..94b3492dc301 100644
> --- a/Documentation/dontdiff
> +++ b/Documentation/dontdiff
> @@ -262,7 +262,7 @@ vsyscall_32.lds
>  wanxlfw.inc
>  uImage
>  unifdef
> -utf8data.h
> +utf8data.c
>  wakeup.bin
>  wakeup.elf
>  wakeup.lds

I'll apply this, but does anybody actually use the dontdiff file
anymore?  I think it's old and, if being used, actively harmful; for
example, it masks changes to "parse.c", an instance of which was added
to git in January.

Is there a reason to not just remove this file?

Thanks,

jon

  reply	other threads:[~2024-08-08 13:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08  8:57 [PATCH] Documentation: dontdiff: remove 'utf8data.h' Guo Xuenan
2024-08-08 13:17 ` Jonathan Corbet [this message]
2024-08-10  8:46   ` Guo Xuenan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sevfp30w.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=ganjie5@huawei.com \
    --cc=guoxuenan@huawei.com \
    --cc=guoxuenan@huaweicloud.com \
    --cc=jack.qiu@huawei.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox