From: Thomas Gleixner <tglx@linutronix.de>
To: Nathan Chancellor <nathan@kernel.org>, shuah@kernel.org
Cc: oleg@redhat.com, anna-maria@linutronix.de, frederic@kernel.org,
ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
patches@lists.linux.dev, John Stultz <jstultz@google.com>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn
Date: Fri, 12 Apr 2024 14:05:47 +0200 [thread overview]
Message-ID: <87sezqzsys.ffs@tglx> (raw)
In-Reply-To: <20240411-mark-kselftest-exit-funcs-noreturn-v1-1-b027c948f586@kernel.org>
On Thu, Apr 11 2024 at 11:45, Nathan Chancellor wrote:
> I have based this change on timers/urgent, as the commit that introduces
> this particular warning is there and it is marked for stable, even
> though this appears to be a generic kselftest issue. I think it makes
> the most sense for this change to go via timers/urgent with Shuah's ack.
> While __noreturn with a return type other than 'void' does not make much
> sense semantically, there are many places that these functions are used
> as the return value for other functions such as main(), so I did not
> change the return type of these functions from 'int' to 'void' to
> minimize the necessary changes for a backport (it is an existing issue
> anyways).
Hrmm. This really want's to be fixed once the change hits Linus tree as this:
static inline __noreturn int ksft_exit_pass(void)
looks seriously broken :)
next prev parent reply other threads:[~2024-04-12 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 18:45 [PATCH] kselftest: Mark functions that unconditionally call exit() as __noreturn Nathan Chancellor
2024-04-11 21:11 ` Shuah Khan
2024-04-12 12:05 ` Thomas Gleixner [this message]
2024-04-12 16:09 ` Nathan Chancellor
2024-04-12 12:15 ` [tip: timers/urgent] selftests: " tip-bot2 for Nathan Chancellor
2024-04-12 16:08 ` [PATCH] " Bill Wendling
2024-04-12 16:11 ` Bill Wendling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sezqzsys.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oleg@redhat.com \
--cc=patches@lists.linux.dev \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox