From: Takashi Iwai <tiwai@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ALSA: echoaudio: remove redundant assignment to variable clock
Date: Thu, 22 Feb 2024 10:05:50 +0100 [thread overview]
Message-ID: <87sf1k6f81.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240221113809.3410109-1-colin.i.king@gmail.com>
On Wed, 21 Feb 2024 12:38:09 +0100,
Colin Ian King wrote:
>
> The variable clock is being assigned a value that is never read,
> it is being re-assigned a new value in every case in the following
> switch statement. The assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> sound/pci/echoaudio/echoaudio_3g.c:277:2: warning: Value stored
> to 'clock' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks, applied.
Takashi
prev parent reply other threads:[~2024-02-22 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 11:38 [PATCH][next] ALSA: echoaudio: remove redundant assignment to variable clock Colin Ian King
2024-02-22 9:05 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sf1k6f81.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox