From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E2FC4332F for ; Wed, 13 Dec 2023 18:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442174AbjLMSSt (ORCPT ); Wed, 13 Dec 2023 13:18:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233776AbjLMSSs (ORCPT ); Wed, 13 Dec 2023 13:18:48 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E2C8B2 for ; Wed, 13 Dec 2023 10:18:55 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA7DBC433C8; Wed, 13 Dec 2023 18:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702491534; bh=PjfwdZOSR2dwBs3EAJKkgyjx0b0MU1xrVZTWAWbnAYg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PC5RWoWME/Cb01hoJ4tntBmUrXtAKuXoxFLNoat77qpUCkpi6EHqrE/iIP2i9e9eP oXMkSt/45erQi7CTpnE9V/5F8/bz91tZHHLkEayh1Gxeam5OUf5uPEulZnRCBflOnD ulDOExq2qlbPkWGzDJ//bBMkrqUKzApzlhW6S3bSaoj6lCiC83x37rXKHjPSFGNbly abUHlvrBUFnWh4vNcuunwFVNdZp7LcEgxOaVUHtSMwVEDupR7gXNSOm47xS+A9pBjE IgMYMA6dnziiUQVe36g3uBnISWV4iSORhMxnEaYUDDG97RJY8W9QjRD+77ZZj3u3CC agrZuxgTksK3w== From: Kalle Valo To: rwahler@gmx.net Cc: linux-kernel@vger.kernel.org, Sultan Alsawaf , linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/2] wifi: mt76: mt7921: Disable powersaving by default References: <874jgmnud8.fsf@kernel.org> <20231213172757.46199-1-rwahler@gmx.net> Date: Wed, 13 Dec 2023 20:18:51 +0200 In-Reply-To: <20231213172757.46199-1-rwahler@gmx.net> (rwahler@gmx.net's message of "Wed, 13 Dec 2023 18:27:57 +0100") Message-ID: <87sf46m0dw.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (adding back linux-wireless, please don't drop lists and people from Cc) rwahler@gmx.net writes: > From: Sultan Alsawaf > > Sultan Alsawaf writes: > >> 3. For insignificant/low-bandwidth traffic like ICMP to the AP, high latency is >> expected since the amount of traffic doesn't warrant kicking the chipset out >> of powersave. So although it's not pretty to look at, bad ping times to the >> AP aren't representative of the full user experience. > > Without the proposed patch ping times are often > 3000ms with a packet > loss of ~20%. And it's not only ICMP packets because i.e. ssh to the > laptop is also not working. It is unusable slow and very often the > connection breaks completely. To which direction? When reporting power save issues it's a good idea to be specific as possible, we don't have crystal balls. > Kalle Valo writes: > >> Mario Limonciello writes: >> >> > Several users have reported awful latency when powersaving is enabled >> > with certain access point combinations. >> >> What APs are these exactly? In the past 802.11 Power Save Mode was >> challenging due to badly behaving APs. But nowadays with so many mobile >> devices in the market I would assume that APs work a lot better. It >> would be best to investigate the issues in detail and try to fix them in >> mt76, assuming the bugs are in mt76 driver or firmware. > > I'm using a FritzBox 6591 Cable Router with latest Firmware for Wlan > and use a Framework13 Laptop with built in MT7921 module. I can > reliably reproduce the problem with high round trip times and packet > loss for inbound connections. Have you tried other clients with that AP? Especially mobile devices like phones is good to test, they usually have pretty aggressive power savings. Also testing with other APs is good. > If i can help with some tests to find the problem i'm happy to support you. I don't know about mt76 driver internals but hopefully others can help. But what I recommend is to provide comprehensive and detailed bug reports, even better if you can include a 802.11 frame capture from a sniffer. Just saying "it doesn't work" doesn't get very far. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches