public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: "Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Regressions" <regressions@lists.linux.dev>,
	"Linux LEDs" <linux-leds@vger.kernel.org>,
	"Tim Crawford" <tcrawford@system76.com>,
	"Jeremy Soller" <jeremy@system76.com>,
	"System76 Product Development" <productdev@system76.com>,
	"Lee Jones" <lee@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
	"Johannes Penßel" <johannes.penssel@gmail.com>
Subject: Re: Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd_backlight/color
Date: Mon, 20 Nov 2023 14:53:51 +0100	[thread overview]
Message-ID: <87sf50pm34.wl-tiwai@suse.de> (raw)
In-Reply-To: <ZUjnzB2RL2iLzIQG@debian.me>

On Mon, 06 Nov 2023 14:19:08 +0100,
Bagas Sanjaya wrote:
> 
> On Sat, Nov 04, 2023 at 01:01:56PM +0100, Jean-Jacques Hiblot wrote:
> > 
> > 
> > On 29/10/2023 02:48, Bagas Sanjaya wrote:
> > > On Thu, Oct 26, 2023 at 02:55:06PM +0700, Bagas Sanjaya wrote:
> > > > The culprit seems to be commit c7d80059b086c4986cd994a1973ec7a5d75f8eea, which introduces a new 'color' attribute for led sysfs class devices. The problem is that the system76-acpi platform driver tries to create the exact same sysfs attribute itself for the system76_acpi::kbd_backlight device, leading to the conflict. For testing purposes, I've just rebuilt the kernel with the system76-apci color attribute renamed to kb_color, and that fixes the issue.
> > > 
> > > Jean-Jacques Hiblot, would you like to take a look on this regression,
> > > since you authored the culprit?
> > Hi,
> > 
> > The offending commit stores the color in struct led_classdev and exposes it
> > via sysfs. It was part of a series that create a RGB leds from multiple
> > single-color LEDs. for this series, we need the color information but we
> > don't really need to expose it it via sysfs. In order to fix the issue, we
> > can remove the 'color' attribute from the sysfs.
> > 
> 
> OK, see you in the patch!

Is there a patch available?

This bug hits for a few Logitech keyboard models, too, and it makes
6.6 kernel unsable for them, as hid-lg-g15 driver probe fails due to
this bug:
  https://bugzilla.kernel.org/show_bug.cgi?id=218155

We need a quick fix for 6.6.x.


Thanks!

Takashi

  reply	other threads:[~2023-11-20 13:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-26  7:55 Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd_backlight/color Bagas Sanjaya
2023-10-29  1:48 ` Bagas Sanjaya
2023-11-04 12:01   ` Jean-Jacques Hiblot
2023-11-06 13:19     ` Bagas Sanjaya
2023-11-20 13:53       ` Takashi Iwai [this message]
2023-11-21  9:19         ` Thorsten Leemhuis
2023-11-21  9:52           ` Takashi Iwai
2023-11-21  9:56             ` Takashi Iwai
2023-11-21 10:21             ` Hans de Goede
2023-11-21 10:33               ` Takashi Iwai
2023-11-21 11:45                 ` Bagas Sanjaya
2023-11-21 12:23                 ` Hans de Goede
2023-11-21 14:26                   ` Takashi Iwai
2023-11-21 15:15           ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf50pm34.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=bagasdotme@gmail.com \
    --cc=jeremy@system76.com \
    --cc=jjhiblot@traphandler.com \
    --cc=johannes.penssel@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=productdev@system76.com \
    --cc=regressions@lists.linux.dev \
    --cc=tcrawford@system76.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox