From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB08C197A0 for ; Mon, 20 Nov 2023 13:54:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232632AbjKTNyg (ORCPT ); Mon, 20 Nov 2023 08:54:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233672AbjKTNyS (ORCPT ); Mon, 20 Nov 2023 08:54:18 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D23CFD7D; Mon, 20 Nov 2023 05:53:53 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 78996218CE; Mon, 20 Nov 2023 13:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700488432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CTYLP+h8hmQrs9+7usiM0wn1wk+0APnN9HJqgLk7Tnw=; b=xu8zQ08b/CDnUNoWT9YB7z0JQDB2+QUTSb/Sr4QNpAt3bskAMSh5hu0eQc8ulSQUSc0N90 54+U5UfKmwnnUZlbpv6W5/XHRIKoUhU3C6Y+adPyTg8k7byXQIHj+NjuWu/YMqvI5QYjCu 9DhjJIvWVB4vw1ErUEEzjdtGqtzxxus= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700488432; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CTYLP+h8hmQrs9+7usiM0wn1wk+0APnN9HJqgLk7Tnw=; b=sCk0B1YwcnrFdjDaEAE3GcyGtQRt2vlOZn+mkOLJtmLBVGGImPgrS87UXBJAv7MqCOwlXl 8mp334lh/fcDmZCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3328913499; Mon, 20 Nov 2023 13:53:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WGZ8C/BkW2VkDQAAMHmgww (envelope-from ); Mon, 20 Nov 2023 13:53:52 +0000 Date: Mon, 20 Nov 2023 14:53:51 +0100 Message-ID: <87sf50pm34.wl-tiwai@suse.de> From: Takashi Iwai To: Jean-Jacques Hiblot Cc: Bagas Sanjaya , Linux Kernel Mailing List , Linux Regressions , Linux LEDs , Tim Crawford , Jeremy Soller , System76 Product Development , Lee Jones , Pavel Machek , Johannes =?ISO-8859-1?Q?Pe?= =?ISO-8859-1?Q?n=DFel?= Subject: Re: Fwd: sysfs: cannot create duplicate filename .../system76_acpi::kbd_backlight/color In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [0.30 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; BAYES_HAM(-0.90)[86.01%]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[11]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[gmail.com,vger.kernel.org,lists.linux.dev,system76.com,kernel.org,ucw.cz]; RCVD_COUNT_TWO(0.00)[2]; SUSPICIOUS_RECIPS(1.50)[] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Nov 2023 14:19:08 +0100, Bagas Sanjaya wrote: > > On Sat, Nov 04, 2023 at 01:01:56PM +0100, Jean-Jacques Hiblot wrote: > > > > > > On 29/10/2023 02:48, Bagas Sanjaya wrote: > > > On Thu, Oct 26, 2023 at 02:55:06PM +0700, Bagas Sanjaya wrote: > > > > The culprit seems to be commit c7d80059b086c4986cd994a1973ec7a5d75f8eea, which introduces a new 'color' attribute for led sysfs class devices. The problem is that the system76-acpi platform driver tries to create the exact same sysfs attribute itself for the system76_acpi::kbd_backlight device, leading to the conflict. For testing purposes, I've just rebuilt the kernel with the system76-apci color attribute renamed to kb_color, and that fixes the issue. > > > > > > Jean-Jacques Hiblot, would you like to take a look on this regression, > > > since you authored the culprit? > > Hi, > > > > The offending commit stores the color in struct led_classdev and exposes it > > via sysfs. It was part of a series that create a RGB leds from multiple > > single-color LEDs. for this series, we need the color information but we > > don't really need to expose it it via sysfs. In order to fix the issue, we > > can remove the 'color' attribute from the sysfs. > > > > OK, see you in the patch! Is there a patch available? This bug hits for a few Logitech keyboard models, too, and it makes 6.6 kernel unsable for them, as hid-lg-g15 driver probe fails due to this bug: https://bugzilla.kernel.org/show_bug.cgi?id=218155 We need a quick fix for 6.6.x. Thanks! Takashi