From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1726EC4167D for ; Mon, 6 Nov 2023 11:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbjKFLX1 (ORCPT ); Mon, 6 Nov 2023 06:23:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjKFLXZ (ORCPT ); Mon, 6 Nov 2023 06:23:25 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7601BBB for ; Mon, 6 Nov 2023 03:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699269802; x=1730805802; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=mHD5i5vDa1OTKSAAbvoZP2HSropGa5tKX66nmBUNaYk=; b=OZ230BlHYihfIpX7OHqE6UVevqcB8WkfUqi1QWVX1yXWp+msxzEHrQu7 xZZC3UV1nm+ZJgsTKlmLlubi7tZHVOb4tlxi0RkUnFtc44AduZpg9Co4/ YM1A5+pz/NVrDj8UTLm3lYWHqm4+jCchwJhiSNxxahabxt3oHCRalOPfl sSvEwmIr0UQ/D+DHSJKeEx1Pi16Y9dFnyPc4oEUAnnTvkMC3oiWFMkLpE K6XjaHAhYtbEdO0IETZP9VmgYuiuPTyFmmksw6RbU7EB5OzZLkDfecwwq RoIaGfVTX7JrIw6MLSYVWNFcpGldlL8NMr/UbHiP/81K0YKEh0ILAgXko A==; X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="393150985" X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="393150985" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 03:23:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="3597494" Received: from lpilolli-mobl.ger.corp.intel.com (HELO localhost) ([10.252.36.222]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 03:23:17 -0800 From: Jani Nikula To: Abhinav Singh , alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch Cc: Abhinav Singh , linux-kernel-mentees@lists.linuxfoundation.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: gpu: Fix warning using plain integer as NULL In-Reply-To: <20231103155013.332367-1-singhabhinav9051571833@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231103155013.332367-1-singhabhinav9051571833@gmail.com> Date: Mon, 06 Nov 2023 13:23:14 +0200 Message-ID: <87sf5jyvkt.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 03 Nov 2023, Abhinav Singh wrote: > sparse static analysis tools generate a warning with this message > "Using plain integer as NULL pointer". In this case this warning is > being shown because we are trying to intialize a pointer to NULL using > integer value 0. > > Signed-off-by: Abhinav Singh > --- > drivers/gpu/drm/radeon/clearstate_evergreen.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/clearstate_evergreen.h b/drivers/gpu/drm/radeon/clearstate_evergreen.h > index 63a1ffbb3ced..3b645558f133 100644 > --- a/drivers/gpu/drm/radeon/clearstate_evergreen.h > +++ b/drivers/gpu/drm/radeon/clearstate_evergreen.h > @@ -1049,7 +1049,7 @@ static const struct cs_extent_def SECT_CONTEXT_defs[] = > {SECT_CONTEXT_def_5, 0x0000a29e, 5 }, > {SECT_CONTEXT_def_6, 0x0000a2a5, 56 }, > {SECT_CONTEXT_def_7, 0x0000a2de, 290 }, > - { 0, 0, 0 } > + { NULL, 0, 0 } Random drive-by comment: I'd just use {} as the sentinel. BR, Jani. > }; > static const u32 SECT_CLEAR_def_1[] = > { > @@ -1060,7 +1060,7 @@ static const u32 SECT_CLEAR_def_1[] = > static const struct cs_extent_def SECT_CLEAR_defs[] = > { > {SECT_CLEAR_def_1, 0x0000ffc0, 3 }, > - { 0, 0, 0 } > + { NULL, 0, 0 } > }; > static const u32 SECT_CTRLCONST_def_1[] = > { > @@ -1070,11 +1070,11 @@ static const u32 SECT_CTRLCONST_def_1[] = > static const struct cs_extent_def SECT_CTRLCONST_defs[] = > { > {SECT_CTRLCONST_def_1, 0x0000f3fc, 2 }, > - { 0, 0, 0 } > + { NULL, 0, 0 } > }; > static const struct cs_section_def evergreen_cs_data[] = { > { SECT_CONTEXT_defs, SECT_CONTEXT }, > { SECT_CLEAR_defs, SECT_CLEAR }, > { SECT_CTRLCONST_defs, SECT_CTRLCONST }, > - { 0, SECT_NONE } > + { NULL, SECT_NONE } > }; > -- > 2.39.2 > -- Jani Nikula, Intel