From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5D3E92FF8 for ; Fri, 6 Oct 2023 08:52:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbjJFIw0 (ORCPT ); Fri, 6 Oct 2023 04:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231277AbjJFIwZ (ORCPT ); Fri, 6 Oct 2023 04:52:25 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C7BFAC for ; Fri, 6 Oct 2023 01:52:23 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F20811F45F; Fri, 6 Oct 2023 08:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696582342; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VCacrZghS4Uqyl1Fty3vrQg56Qi9D9DRPUUtxDf6VS8=; b=KbY3TaaJ+/29hkX5L74ydFqwegEV33LnWQjZKE4YmuRfvUFUrrpnmUCmp5dO6284PBMob1 OCeU7ZVo9/cGSdIby8CDy7KSMraqEfwZfHXKMb6B9XITvcuqV72q7jzKNMhKkPo4XdEl4+ 6DJ9uOFoE53Dx0S4fbOf56/FVscSJpM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696582342; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VCacrZghS4Uqyl1Fty3vrQg56Qi9D9DRPUUtxDf6VS8=; b=BYrg6qlR5CPzQqbZQ+Mn0YCmd/JWIpRmK9CIH8RK14d+9RaDN9oA69q2c/yYgQxOwSdWfR 1aS4VQPIj02jwrDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CC28113A2E; Fri, 6 Oct 2023 08:52:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +1vbMMXKH2XMIwAAMHmgww (envelope-from ); Fri, 06 Oct 2023 08:52:21 +0000 Date: Fri, 06 Oct 2023 10:52:21 +0200 Message-ID: <87sf6ow2t6.wl-tiwai@suse.de> From: Takashi Iwai To: Ivan Orlov Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ALSA: aloop: Add support for the non-interleaved access mode In-Reply-To: <20230927113555.14877-1-ivan.orlov0322@gmail.com> References: <20230927113555.14877-1-ivan.orlov0322@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Sep 2023 13:35:54 +0200, Ivan Orlov wrote: > > The current version of the loopback driver supports interleaved access > mode only. This patch introduces support for the non-interleaved > access mode. > > When in the interleaved mode, the 'copy_play_buf' function copies data > from the playback to the capture buffer using one memcpy call. This call > copies samples for multiple, interleaved channels. > > In the non-interleaved mode we have multiple channel buffers, so we have > to perform multiple memcpy calls to copy samples channel after channel. > > Add new function called 'copy_play_buf_part_n', which copies a part of > each channel buffer from playback to capture. Modify the 'copy_play_buf' > to use the corresponding memory copy function(just memcpy / > copy_play_buf_part_n) depending on the access mode. > > Signed-off-by: Ivan Orlov Sorry for the late reaction, as I've been (still) off since the last week. Now applied both patches. Thanks. Takashi