public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] serial: core: fix kernel-doc for uart_port_unlock_irqrestore()
@ 2023-09-27  4:41 Randy Dunlap
  2023-09-27  7:39 ` John Ogness
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-09-27  4:41 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Thomas Gleixner, John Ogness, linux-serial,
	Greg Kroah-Hartman, Jiri Slaby

Fix the function name to avoid a kernel-doc warning:

include/linux/serial_core.h:666: warning: expecting prototype for uart_port_lock_irqrestore(). Prototype was for uart_port_unlock_irqrestore() instead

Fixes: b0af4bcb4946 ("serial: core: Provide port lock wrappers")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
---
 include/linux/serial_core.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/include/linux/serial_core.h b/include/linux/serial_core.h
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -658,7 +658,7 @@ static inline void uart_port_unlock_irq(
 }
 
 /**
- * uart_port_lock_irqrestore - Unlock the UART port, restore interrupts
+ * uart_port_unlock_irqrestore - Unlock the UART port, restore interrupts
  * @up:		Pointer to UART port structure
  * @flags:	The saved interrupt flags for restore
  */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] serial: core: fix kernel-doc for uart_port_unlock_irqrestore()
  2023-09-27  4:41 [PATCH -next] serial: core: fix kernel-doc for uart_port_unlock_irqrestore() Randy Dunlap
@ 2023-09-27  7:39 ` John Ogness
  0 siblings, 0 replies; 2+ messages in thread
From: John Ogness @ 2023-09-27  7:39 UTC (permalink / raw)
  To: Randy Dunlap, linux-kernel
  Cc: Randy Dunlap, Thomas Gleixner, linux-serial, Greg Kroah-Hartman,
	Jiri Slaby

On 2023-09-26, Randy Dunlap <rdunlap@infradead.org> wrote:
> Fix the function name to avoid a kernel-doc warning:
>
> include/linux/serial_core.h:666: warning: expecting prototype for uart_port_lock_irqrestore(). Prototype was for uart_port_unlock_irqrestore() instead
>
> Fixes: b0af4bcb4946 ("serial: core: Provide port lock wrappers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: John Ogness <john.ogness@linutronix.de>
> Cc: linux-serial@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>

Thanks for catching and fixing this.

Reviewed-by: John Ogness <john.ogness@linutronix.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-27  7:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27  4:41 [PATCH -next] serial: core: fix kernel-doc for uart_port_unlock_irqrestore() Randy Dunlap
2023-09-27  7:39 ` John Ogness

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox